Make translate test handle no translate packages installed.#4786
Merged
Conversation
wes-otf
pushed a commit
to OpenTechFund/apply-app
that referenced
this pull request
Apr 6, 2026
…#4786) This fix loads the urls that loads the views before tests are run. This avoid them being loaded after @override_settings() have run. The problem showed up in `test_staff_can_see_translate_primary_action()` test that have `@override_settings(APPLICATION_TRANSLATIONS_ENABLED=True)`. Loading views after `@override_settings(APPLICATION_TRANSLATIONS_ENABLED=True)` made them look for translation packages that were not installed resulting in failed tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix loads the urls that loads the views before tests are run. This avoid them being loaded after @override_settings() have run.
The problem showed up in
test_staff_can_see_translate_primary_action()test that have@override_settings(APPLICATION_TRANSLATIONS_ENABLED=True).Loading views after
@override_settings(APPLICATION_TRANSLATIONS_ENABLED=True)made them look for translation packages that were not installed resulting in failed tests.