Conversation
…with comment priveledges
wes-otf
force-pushed
the
maintenance/remove-partner-role
branch
from
dfd8ad8 to
39c7b4b
Compare
frjo
requested changes
Mar 31, 2026
Member
frjo
left a comment
frjo
left a comment
There was a problem hiding this comment.
This looks good.
One "x" to many in the code and there are some mentions of Partners in the docs we should remove.
docs/user-guides/creating-a-user-account.md
docs/references/user-roles.md
After that I think it is good to go.
We need to state this change clearly in the release notes so organisations using partners know what will happen.
hypha/apply/activity/models.py
Outdated
| # `user_qs` (ie. A comment made only to staff from a partner). | ||
| if user.is_applicant: | ||
| # Handle the edge case where a partner or reviewer is also an | ||
| # Handle the edge case where a xreviewer is also an |
| name=PARTNER_GROUP_NAME | ||
| ).user_set.values_list("id", flat=True) | ||
| Group.objects.get(name="Applicant").user_set.add(*all_partner_ids) | ||
|
|
Contributor
Author
|
Tossed all mentions of partners in the docs! Definitely agree with the release notes aspect. |
frjo
approved these changes
Apr 1, 2026
frjo
added
Type: Enhancement
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4719. Migrates all existing partners to coapplicants with comment privileges and removes the partner role from Hypha. This also handles swapping partner comment visibility to applicant
Test Steps
After migrations are ran confirm...
partnersorapplicant partners) are nowapplicant