Code quality sweep + PROGRESS.md v2 replan - #76
Merged
Conversation
- Run ruff check --fix and ruff format (100 files reformatted) - Replace datetime.utcnow() with datetime.now(timezone.utc) across 6 source files + 1 doc - Fix MD5-based deal ID generation with usedforsecurity=False in 2 files bead: ar-pkji Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Narrow overly broad except Exception catches to specific types across 28 source files (77 occurrences total): * DealStore persistence: sqlite3.Error, OSError, ValueError, AttributeError * HTTP client calls: httpx.HTTPError, OSError, ValueError * Pydantic model construction: ValueError, TypeError * MCP/UCP transport: httpx.HTTPError, ValueError, RuntimeError * API route handlers: ValueError, TypeError, KeyError, OSError - Annotate intentionally broad catches with # noqa: BLE001 comments explaining the design rationale (17 occurrences): * Event bus subscriber isolation * Event emission fail-open pattern * CrewAI flow step handlers * CLI/background task top-level handlers * Per-seller/per-channel isolation loops - Add docs/CODING_STANDARDS.md with 14 standards from code quality audit - Fix test_deals_client side_effect to use OSError instead of Exception bead: ar-rx35 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Phase 3: Add AI Assistant epic (buyer-mw9) with 10 MCP tool beads - Phase 4: Rename to Deal Library & External Hooks, remove dropped beads - Remove 3A/3B/3C/3D/3E prefixes, clean titles - Show blocker dependencies Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime.utcnow()withdatetime.now(timezone.utc)(30+ occurrences)usedforsecurity=False)except Exceptioncatches to specific typesdocs/CODING_STANDARDS.md(14 standards from code quality audit)Test plan
🤖 Generated with Claude Code