-
Notifications
You must be signed in to change notification settings - Fork 50
Android/iOS SDK page adding mobile CSTG info #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/sdks/uid2-sdk-ref-android.md
Outdated
| The initial UID2 Identity *must* be generated by the implementing application and then passed into the UID2 SDK. Because of security requirements, the UID2 Mobile SDKs cannot create new UID2 identities. | ||
| There are two ways to establish an initial UID2 Identity: | ||
|
|
||
| 1. Generate the UID2 identity using a DII - email (hash) or phone no (hash). For integration instructions, refer to [Client-Server Integration Guide for Mobile](https://ttdcorp-my.sharepoint.com/:w:/g/personal/sunny_wu_thetradedesk_com/EX2dEa2NAcRPs3Pfchwua40ByY0g0DASgLybKJs11TLHqw?e=vxRjFa). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will replace these word doc links to proper unifiedid.com pages before merging
docs/sdks/uid2-sdk-ref-ios.md
Outdated
| ### Installing with Xcode | ||
| Add the following dependency via Xcode: | ||
| Add the following dependency via Xcode Package Dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcaunt i want to replace the screenshot as shown on https://unifiedid.com/docs/sdks/uid2-sdk-ref-ios#installing-with-xcode as everytime we make a new release we need to create a new screenshot.
Please let me know if this description and table below makes the same info clear or not, and if not, how we could improve it. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @dcaunt i have corrected it per your suggestion and i reworded the top description from:
Add the following dependency via Xcode Package Dependencies:
to
Add the following entry in your application's Package Dependencies:
which may be clearer
…e SDK description to mention 'generate identity' too
| #### setIdentity() | ||
|
|
||
| Sets the UID2 Identity to be managed by the SDK. | ||
| Sets a UID2 Identity created from backend server to be managed by the SDK. Refer to [Client-Server Integration Guide for Mobile](https://ttdcorp-my.sharepoint.com/:w:/g/personal/sunny_wu_thetradedesk_com/EX2dEa2NAcRPs3Pfchwua40ByY0g0DASgLybKJs11TLHqw?e=vxRjFa) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sunnywu . For iOS, generateIdentity links to Client-Server guide and setIdentity links to Client-Side guide. Is this the wrong way around?
Here is Android: generateIdentity links to Client-Side guide and setIdentity links to client-server guide. Is it correct that these two are the opposite way around?
FYI I'm incorporating these mods into my PR as we discussed last night. This is my main question but I have a couple more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes ios has wrong way around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in mine but please cross-check. Thx!
|
#557 already included the changes in this PR. closing |

Android/iOS SDK Reference for publishers who want to establish client identity using UID2
to
Android/iOS SDK reference for publishers who want to generate or establish client identity using UID2
as we are adding token generation functionality to both SDKs