Skip to content

Conversation

@sunnywu
Copy link
Contributor

@sunnywu sunnywu commented Apr 29, 2024

  1. This PR won't be merged until @genwhittTTD has converted the Word mobile integration guides into markdown pages in this repo and replace the Word doc links in this PR with actual doc site links
  2. I am proposing to have a tvOS section in the UID2 SDK for iOS reference guide to mention it does support tvOS. Also, in android guide, to mention it support other non-mobile android devices too.
  3. I have modified the description
    Android/iOS SDK Reference for publishers who want to establish client identity using UID2
    to
    Android/iOS SDK reference for publishers who want to generate or establish client identity using UID2
    as we are adding token generation functionality to both SDKs

@sunnywu sunnywu requested review from IanDBird and dcaunt April 29, 2024 08:06
The initial UID2 Identity *must* be generated by the implementing application and then passed into the UID2 SDK. Because of security requirements, the UID2 Mobile SDKs cannot create new UID2 identities.
There are two ways to establish an initial UID2 Identity:

1. Generate the UID2 identity using a DII - email (hash) or phone no (hash). For integration instructions, refer to [Client-Server Integration Guide for Mobile](https://ttdcorp-my.sharepoint.com/:w:/g/personal/sunny_wu_thetradedesk_com/EX2dEa2NAcRPs3Pfchwua40ByY0g0DASgLybKJs11TLHqw?e=vxRjFa).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will replace these word doc links to proper unifiedid.com pages before merging

@sunnywu sunnywu changed the title Android SDK page adding mobile CSTG info Android/iOS SDK page adding mobile CSTG info Apr 30, 2024
### Installing with Xcode
Add the following dependency via Xcode:
Add the following dependency via Xcode Package Dependencies:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcaunt i want to replace the screenshot as shown on https://unifiedid.com/docs/sdks/uid2-sdk-ref-ios#installing-with-xcode as everytime we make a new release we need to create a new screenshot.

Please let me know if this description and table below makes the same info clear or not, and if not, how we could improve it. Thanks

Copy link
Contributor

@dcaunt dcaunt May 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That view has improved a little in the latest versions of Xcode:

image

I think something like this would be good:

| Name | Location | Dependency Rule |
| :--- | :--- |:-----------------------------| 
| uid2-ios-sdk | git@github.com:IABTechLab/uid2-ios-sdk.git | Up to next major version: 1.0.0 < 2.0.0 |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dcaunt i have corrected it per your suggestion and i reworded the top description from:

Add the following dependency via Xcode Package Dependencies:
to
Add the following entry in your application's Package Dependencies:

which may be clearer

…e SDK description to mention 'generate identity' too
@sunnywu sunnywu self-assigned this May 1, 2024
@sunnywu sunnywu marked this pull request as ready for review May 1, 2024 06:11
@sunnywu sunnywu requested a review from genwhittTTD May 2, 2024 05:52
#### setIdentity()

Sets the UID2 Identity to be managed by the SDK.
Sets a UID2 Identity created from backend server to be managed by the SDK. Refer to [Client-Server Integration Guide for Mobile](https://ttdcorp-my.sharepoint.com/:w:/g/personal/sunny_wu_thetradedesk_com/EX2dEa2NAcRPs3Pfchwua40ByY0g0DASgLybKJs11TLHqw?e=vxRjFa)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sunnywu . For iOS, generateIdentity links to Client-Server guide and setIdentity links to Client-Side guide. Is this the wrong way around?
Here is Android: generateIdentity links to Client-Side guide and setIdentity links to client-server guide. Is it correct that these two are the opposite way around?
FYI I'm incorporating these mods into my PR as we discussed last night. This is my main question but I have a couple more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ios has wrong way around

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in mine but please cross-check. Thx!

@sunnywu
Copy link
Contributor Author

sunnywu commented May 21, 2024

#557 already included the changes in this PR. closing

@sunnywu sunnywu closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants