Skip to content

Conversation

@genwhittTTD
Copy link
Collaborator

@genwhittTTD genwhittTTD commented May 3, 2024

Add two new mobile integration guides plus overview, and mods to associated files (many).

@genwhittTTD genwhittTTD marked this pull request as draft May 3, 2024 21:21
@genwhittTTD genwhittTTD requested a review from sunnywu May 3, 2024 21:21
…nd simplified Add the UID2 Mobile SDK into Your Mobile App section in client-server guide
Copy link
Contributor

@asloobq asloobq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed client side integration

<TabItem value='android' label='Android'>

1. Check out the main branch of the [UID2 SDK for Android source code repository on GitHub](https://github.com/IABTechLab/uid2-android-sdk/tree/main).
1. In Android Studio, open the directory that you checked out.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that the minimum version of Android Studio required is "Jellyfish | 2023.3.1" ?
I was using Iguana and getting an error saying the "project is built with AGP 8.4"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunnywu your call on this one please.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have modified to:

In Android Studio (Jellyfish/v2023.3.1 or whichever future version supports the Android Gradle Plugin version required by the UID2 SDK for Android release at the time), open the directory that you checked out.

Install the UID2 iOS IMA Plugin via Swift Package Manager to an existing app with the UID2 SDK for iOS and the Google Interactive Media Ads SDK installed.

```
.package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-ima.git, exact: "0.3.0")
Copy link
Contributor

@dcaunt dcaunt May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of url should be wrapped in quote marks, as per the value of exact, i.e.

Suggested change
.package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-ima.git, exact: "0.3.0")
.package(url: "https://github.com/IABTechLab/uid2-ios-plugin-google-ima.git", exact: "0.3.0")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcaunt great catch! Fixed, thx.


``` javascript
```js
.package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git, exact: "0.2.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git, exact: "0.2.0")
.package(url: "https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git", exact: "0.2.0")

``` javascript
```js
dependencies: [
.package(url: \"https://github.com/IABTechLab/uid2-ios-sdk.git\", from: "0.2.0"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.package(url: \"https://github.com/IABTechLab/uid2-ios-sdk.git\", from: "0.2.0"),
.package(url: "https://github.com/IABTechLab/uid2-ios-sdk.git", from: "0.2.0"),

Copy link
Collaborator Author

@genwhittTTD genwhittTTD May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcaunt just FYI I updated this to be as per the English version, your next edit:

.package(url: "https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git", exact: "0.3.0")

Copy link
Contributor

@dcaunt dcaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor notes but on the whole looks great from iOS perspective! Thanks!


``` javascript
```js
.package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git, exact: "0.3.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git, exact: "0.3.0")
.package(url: "https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git", exact: "0.3.0")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! And this resolves my query from your previous edit.

Copy link
Contributor

@asloobq asloobq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client side integration reviewed 👍

sunnywu added 3 commits May 17, 2024 15:09
…ion as optout status for cstg isn't enabled in production yet
…ould suggest publishers to think long term as we will start sending cstg optout response soon
**Android Java**:

```java
UID2Manager.getInstance()setAutomaticRefreshEnabled(false)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Same as other comment, missing .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. TYSM.

@genwhittTTD genwhittTTD merged commit 2c35d17 into main May 17, 2024
@genwhittTTD genwhittTTD deleted the gwh-APIDOCS-1903-mobile-integration-docs branch November 22, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants