-
Notifications
You must be signed in to change notification settings - Fork 50
Gwh apidocs 1903 mobile integration docs #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i18n/ja/docusaurus-plugin-content-docs/current/guides/integration-mobile-client-server.md
Outdated
Show resolved
Hide resolved
i18n/ja/docusaurus-plugin-content-docs/current/guides/integration-mobile-client-server.md
Outdated
Show resolved
Hide resolved
i18n/ja/docusaurus-plugin-content-docs/current/guides/integration-mobile-client-server.md
Outdated
Show resolved
Hide resolved
i18n/ja/docusaurus-plugin-content-docs/current/guides/integration-mobile-client-server.md
Outdated
Show resolved
Hide resolved
i18n/ja/docusaurus-plugin-content-docs/current/guides/integration-mobile-client-server.md
Show resolved
Hide resolved
i18n/ja/docusaurus-plugin-content-docs/current/guides/integration-mobile-client-server.md
Show resolved
Hide resolved
…nd simplified Add the UID2 Mobile SDK into Your Mobile App section in client-server guide
asloobq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed client side integration
| <TabItem value='android' label='Android'> | ||
|
|
||
| 1. Check out the main branch of the [UID2 SDK for Android source code repository on GitHub](https://github.com/IABTechLab/uid2-android-sdk/tree/main). | ||
| 1. In Android Studio, open the directory that you checked out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that the minimum version of Android Studio required is "Jellyfish | 2023.3.1" ?
I was using Iguana and getting an error saying the "project is built with AGP 8.4"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunnywu your call on this one please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have modified to:
In Android Studio (Jellyfish/v2023.3.1 or whichever future version supports the Android Gradle Plugin version required by the UID2 SDK for Android release at the time), open the directory that you checked out.
docs/guides/mobile-plugin-ima-ios.md
Outdated
| Install the UID2 iOS IMA Plugin via Swift Package Manager to an existing app with the UID2 SDK for iOS and the Google Interactive Media Ads SDK installed. | ||
|
|
||
| ``` | ||
| .package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-ima.git, exact: "0.3.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of url should be wrapped in quote marks, as per the value of exact, i.e.
| .package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-ima.git, exact: "0.3.0") | |
| .package(url: "https://github.com/IABTechLab/uid2-ios-plugin-google-ima.git", exact: "0.3.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcaunt great catch! Fixed, thx.
|
|
||
| ``` javascript | ||
| ```js | ||
| .package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git, exact: "0.2.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git, exact: "0.2.0") | |
| .package(url: "https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git", exact: "0.2.0") |
| ``` javascript | ||
| ```js | ||
| dependencies: [ | ||
| .package(url: \"https://github.com/IABTechLab/uid2-ios-sdk.git\", from: "0.2.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .package(url: \"https://github.com/IABTechLab/uid2-ios-sdk.git\", from: "0.2.0"), | |
| .package(url: "https://github.com/IABTechLab/uid2-ios-sdk.git", from: "0.2.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcaunt just FYI I updated this to be as per the English version, your next edit:
.package(url: "https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git", exact: "0.3.0")
dcaunt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor notes but on the whole looks great from iOS perspective! Thanks!
docs/guides/mobile-plugin-gma-ios.md
Outdated
|
|
||
| ``` javascript | ||
| ```js | ||
| .package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git, exact: "0.3.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .package(url: https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git, exact: "0.3.0") | |
| .package(url: "https://github.com/IABTechLab/uid2-ios-plugin-google-gma.git", exact: "0.3.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! And this resolves my query from your previous edit.
asloobq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client side integration reviewed 👍
…ndroid studio requirement in client-side guide
…ion as optout status for cstg isn't enabled in production yet
…ould suggest publishers to think long term as we will start sending cstg optout response soon
| **Android Java**: | ||
|
|
||
| ```java | ||
| UID2Manager.getInstance()setAutomaticRefreshEnabled(false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Same as other comment, missing .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. TYSM.
Add two new mobile integration guides plus overview, and mods to associated files (many).