feat(studio): bind Recast, Repaint and Panorama with the shared picker - #241
Merged
Conversation
Replace OS-only file inputs with AssetInput/StudioSourceField. Catalog picks keep server paths via applyChosenStudioMedia. Recast extra views stay one catalog choice at a time up to four. Panorama still prepares the loop after the source is chosen, not inside the picker.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_636449d2-752c-42f0-9b01-02782f4d408f) |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
Code healthQuality score: 54.7/100Higher is better. The score is a trend dashboard; the independent ratchet below remains the CI gate.
Change vs PR base: +0.0 points.
Markdown, JSON catalogs and tests are out of this table. Only Most complex functions
Trend vs baseline
Ratchet passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
G1-A: Recast, Repaint (Restyle) and Panorama use the shared picker instead of OS-only file inputs.
StudioSourceField/AssetInputwithworkspaceId.applyChosenStudioMedia(server path + URL probe, no re-download/re-upload to mint a File).Test plan
recastRestylePicker.test.tsx(3) — dual-origin buttons, explorer stays closedNote
Medium Risk
Touches SCAIL-2 Recast/Repaint edit inputs and how server media paths are bound, though it reuses the same picker helpers as other studio panels.
Overview
Recast, Repaint (Restyle), and Panorama now pick source media through the shared
AssetInput/StudioSourceFieldinstead of drag-and-drop and hidden file inputs, scoped toactiveWorkspaceviauseWorkspaceOutputs.Catalog selections go through
applyChosenStudioMedia, so edit state gets serverpathplus preview URL/metadata without the olduploadImage+ blob-URL upload path. Recast video, primary character refs, and extra views (one library pick at a time, still capped at four) all use this flow; Repaint clears the edited frame when the source video changes; Panorama still fetches the chosen image and runsprepareTripleTileafter selection.Adds
recastRestylePicker.test.tsxto assert dual-origin picker buttons and that the asset explorer stays closed on initial render, plus an architecture wire-inventory entry for the new test.Reviewed by Cursor Bugbot for commit d127cf7. Configure here.