Skip to content

Stabilize CI and docs builds while adding test coverage and code quality tooling#5

Merged
f-utro merged 13 commits into
IBM:mainfrom
blankenberg:feature/tests
Apr 11, 2026
Merged

Stabilize CI and docs builds while adding test coverage and code quality tooling#5
f-utro merged 13 commits into
IBM:mainfrom
blankenberg:feature/tests

Conversation

@blankenberg
Copy link
Copy Markdown
Contributor

Description

This PR adds an initial automated test suite and then follows through with the CI, typing, formatting, and documentation fixes needed to make the project pass consistently in automation.

What Changed

  • Added tests for data generation, generator dispatch, and file utility behavior.
  • Fixed duplicate-file tests to avoid path-order assumptions.
  • Cleaned up formatting across the qbiocode package with black and isort.
  • Added isort configuration and included it in the dev and all extras.
  • Fixed CI type-check failures, including missing types-PyYAML and several mypy issues in learning, embedding, and utility modules.
  • Fixed import-order issues reported by code-quality checks.
  • Updated GitHub Actions workflows, including moving workflows to Node 24.
  • Fixed docs/CI build issues, including Pandoc-related documentation problems.
  • Cleaned up an invalid escape sequence warning in visualization code.

Notes

Most of the churn is repository-wide formatting/import normalization, with the substantive functional changes centered on:

  • new tests
  • CI workflow maintenance
  • docs build fixes
  • typing/code-quality compliance

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Code style update (formatting, renaming)
  • ♻️ Refactoring (no functional changes)
  • ⚡ Performance improvement
  • ✅ Test update
  • 🔧 Configuration change
  • 🔨 Build/CI update

For Maintainers

  • PR title follows conventional commit format
  • Labels are appropriate
  • Milestone is set (if applicable)
  • Documentation is updated
  • Tests are adequate
  • CI/CD passes

Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
…orrelation.py

Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
  - Added types-PyYAML to the dev and all extras in pyproject.toml:81 and setup.py:98, so the lint job’s pip install -e ".[dev]" will provide yaml stubs.
  - Fixed the itertools.product typing complaint in qbiocode/utils/generate_qml_configs.py:146 with an explicit cast for the mixed-type parameter grid.
  - Removed the unsupported gamma argument from PegasosQSVC in qbiocode/learning/compute_qsvc.py:98.
  - Split the QNN network variable from the classifier in qbiocode/learning/compute_qnn.py:94 so mypy can accept both EstimatorQNN and SamplerQNN.
  - Returned explicit float(...) values in qbiocode/learning/compute_pqk.py:104 and qbiocode/embeddings/embed.py:62 to satisfy the declared return type.

Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
Signed-off-by: Daniel Blankenberg <dan.blankenberg@gmail.com>
@f-utro f-utro merged commit 97c56a7 into IBM:main Apr 11, 2026
12 checks passed
f-utro added a commit that referenced this pull request Apr 11, 2026
- Resolved merge conflicts in __init__.py files (data_generation, learning, utils, evaluation)
- Applied black formatting to model_evaluation.py for consistency
- Kept ensemble additions (compute_qensemble, evaluation_metrics, data_encoding, make_blobs)
- Updated to use double quotes for string consistency with main branch
- Integrated testing infrastructure from main (pytest, test files)
- Integrated code quality improvements (black, isort, CI/CD updates)
- Updated CHANGELOG with testing and code quality improvements from PR #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants