Skip to content

refactor(schema): remove temporary handling of mistyped property values #367

Description

@AlessandroPomponio

Issue

For historical reasons we have the following code: https://github.com/IBM/ado/blob/main/orchestrator/schema/property_value.py#L137-L146

This serves as a workaround for an old bug where, if the valueType was not set, it defaulted to NUMERIC even if the value was not a number, such as a string or list.

Our tests track this by xfailing on it: https://github.com/IBM/ado/blob/main/tests/schema/test_property_value.py#L137-L161

We should fix the entities (created before 25/04/25) which may exhibit this issue:

  1. For every entity where there is a mismatch (in constitutive property values or observed property values), read the entity from the db and store it back, along with all its measurements results.
  2. Change check_value_type to raise an error
  3. Remove the XFAIL

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions