Adding the generation of SBOM capability to Common Backend Scripts#274
Merged
Conversation
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
dennis-behm
reviewed
Sep 16, 2024
Member
dennis-behm
left a comment
dennis-behm
left a comment
There was a problem hiding this comment.
Hi @M-DLB
can you please update the README for the CBS to call out the additional options?
I think we could also make a point that this should be rather centrally controlled via the pipelineBackend.config file instead of exposing the -s option to packageBuildOutputs.sh which may require updates to multiple pipelines. However, having the option exposed is a good thing, because probably not all applications want/need the SBOM.
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
dennis-behm
approved these changes
Sep 16, 2024
Member
dennis-behm
left a comment
dennis-behm
left a comment
There was a problem hiding this comment.
Thank you Mathieu for the updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the support to generate SBOM when running the Common Backend Scripts.