Feature/314 enhance jenkins pipeline template to use updated package lifecycle#326
Conversation
dennis-behm
left a comment
dennis-behm
left a comment
There was a problem hiding this comment.
@monvora Thanks for this new contribution. I have commented on your PR with a few remarks.
| if (autoCancelled == false) { | ||
| // Start packageBuildOutputs.sh command | ||
| println("${PipelineName}[INFO]: Run packageBuildOutput.sh") | ||
| if (releaseVersion == "") { |
There was a problem hiding this comment.
Could this be handled a bit more elegantly? Either by introducing a releaseVersionComputed flag that can be true/false?
There was a problem hiding this comment.
Maybe also use a condition based on PipelineType == "release"
| // Add -c ${WdConfigFile} option to the WdGenDeployPlanCmd to overwrite. | ||
| //def WdConfigFile = "/var/WaziDeploy/config/WaziDeploy-ConfigFile.yml" | ||
|
|
||
| WdGenDeployPlanCmd = "wazideploy-generate.sh -w ${WORKSPACE} -a ${AppName} -b ${AppBranch} -P ${PipelineType} -R ${releaseVersion} -I ${BuildNumber}" |
There was a problem hiding this comment.
I believe this command assumes that the pipeline is setup to publish the TAR to Artifactory/Nexus.
Do we need to make it conditional?
There was a problem hiding this comment.
As what we did with GitLab, "Publish" to artifact repository value will be set in pipelineBackend.config file.
| WdDeployCmd = 0 | ||
| MsgHdr = "<strong>Packaging Step:</strong>" | ||
|
|
||
| WdDeployCmd = "wazideploy-deploy.sh -w ${WORKSPACE} -e ${WdEnvFileIntegration} -i ${AppName}.tar -l deploy/evidences/evidence.yaml" |
There was a problem hiding this comment.
-t *.tar is ambiguous here. If the pipeline publishes to Artifactory, then this is no longer required.
| } | ||
| } | ||
| } | ||
| } // End: stage('Deployment-INT') |
There was a problem hiding this comment.
Can you please add the wazideploy-evidence.sh step as well do generate the deploymentReport html file?
There was a problem hiding this comment.
Thanks @monvora to expand on the storing the produced evidences at a central location. I believe we need to do that not only on RC=0 but also when the deployment has failed.
There is one thing that I am missing - in the other pipelines, we have the wazideploy-evidence.sh script to render the deployment report html file. See the CBS details here
Can you please apply something similar like on the Gitlab template and then attach the report to the pipeline results?
…plate-to-use-updated-package-lifecycle
…ties and addressed the review comments.
|
@dennis-behm I addressed all your comments please review. |
dennis-behm
left a comment
dennis-behm
left a comment
There was a problem hiding this comment.
@monvora I have couple of suggestions for the README. Can you please take a look?
| * `SonarQube Analysis` stage to request a SonarQube scan of the application repository. | ||
| * `Packaging` stage | ||
| * to create a .TAR file package based on the [packageBuildOutputs.sh](https://github.com/IBM/dbb/blob/main/Templates/Common-Backend-Scripts/README.md#138---packageBuildOutputssh) script, | ||
| * to automatically compute the version of the next release for a release pipeline via [computeReleaseVersion.sh]((https://github.com/IBM/dbb/blob/main/Templates/Common-Backend-Scripts/README.md#137---computeReleaseVersionsh), |
There was a problem hiding this comment.
Doesn't this have to be lsited before packageBuildOutputs?
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
Co-authored-by: Dennis Behm <dennis.behm@de.ibm.com>
dennis-behm
left a comment
dennis-behm
left a comment
There was a problem hiding this comment.
Thanks for the new flavour of the Jenkins template with Wazi Deploy
2 participants
Uh oh!
There was an error while loading. Please reload this page.