Issue 329 - Improve checks against deletion of high-level directories in CBS cleanup#330
Conversation
Signed-off-by: LAURENL <45975633+lauren-li@users.noreply.github.com>
6fa05e7 to
522a8ad
Compare
Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
973c371 to
ed31178
Compare
Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
M-DLB
left a comment
There was a problem hiding this comment.
I though we also wanted to check that the working dir is a subfolder of the location pointed by $PIPELINE_WORKSPACE.
Would it be possible to implement this check as well? Thank you!
Signed-off-by: Lauren Li <45975633+lauren-li@users.noreply.github.com>
|
@M-DLB After discussing with @dennis-behm, we were thinking to handle the check that the CBS workspace is a child folder of the Because the removal of the capability to specify absolute paths via the |
|
Dropping the support for absolute paths will make our CI/CD pipeline templates for GitLab fail. Maybe other pipelines will be impacted too. This has to be thought carefully! |
dennis-behm
left a comment
There was a problem hiding this comment.
Thanks for the updates to safeguard the deletions of the build workspace
Add the following checks against pipeline deletion of high-level directories in Common Back-end Scripts
deleteWorkspace.sh:-PoptionResolves #329