-
Notifications
You must be signed in to change notification settings - Fork 38
docs: Use sphinx-js #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Use sphinx-js #248
Conversation
|
I created an initial draft of docs using If so I will split this out. |
|
I think it's fine as-is. I set up a readthedocs project, but it's failing to build because sphinx-js is not installed by default. Can you add a docs/requirements.txt and add it to a (new) readthedocs config file. Then, the build should work and we can preview/review the docs at https://nodejs-itoolkit.readthedocs.io/en/use-sphinx-js/ |
|
@kadler I've added the requested files. Can you run another build? |
|
|
Looks like we need to add @kadler Ok, I've specified the master_doc to be index.rst. Lets try another build. |
|
The build has passed: https://nodejs-itoolkit.readthedocs.io/en/use-sphinx-js |
|
I'd like to see the intro page be the pain page. Right now when you go to the docs you just get an index, which is not the best user experience / first impression. |
So I moved the contents of |
|
FYI @abmusse there is a webhook setup already so any pushes automatically trigger a build. |
kadler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look pretty good. I think there's more improvements we can make, but definitely good enough to merge as they are. I'd rather get something up so that we can progress on #209 and other things.
Resolves #95
We now use sphinx-js for documentation.