Skip to content

fix(engine): Fix issues related to accessible name concatenation and deprecate aria_search_label_unique rule V4#2178

Merged
tombrunet merged 9 commits intomain-4.xfrom
dev-2122-v4
Feb 4, 2025
Merged

fix(engine): Fix issues related to accessible name concatenation and deprecate aria_search_label_unique rule V4#2178
tombrunet merged 9 commits intomain-4.xfrom
dev-2122-v4

Conversation

@shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jan 28, 2025

  • Engine bug: accessible name concatenation with spaces and deprecate aria_search_label_unique rule

This PR is related to the following issue(s):

Testing reference:

test/v2/checker/accessibility/rules/label_name_visible_ruleunit/button-label-pass.html
test/v2/checker/accessibility/rules/label_name_visible_ruleunit/button-label-pass2.html

The above test cases trigger an "Accessible name does not match or contain the visible label text".
After the fix, the error should disappear.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other Action Artifacts

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

dependabot bot and others added 8 commits December 16, 2024 09:34
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
…TML report page (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
#1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <thbrunet@us.ibm.com>
Merge from dev-2122-new to dev-2122-v4
@tombrunet tombrunet merged commit a08baf4 into main-4.x Feb 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants