Skip to content

Fix(input_label_visible): fix issues related to the Firefox css pseudo-element V4#2187

Merged
tombrunet merged 2 commits intomain-4.xfrom
dev-2085-v4
Feb 10, 2025
Merged

Fix(input_label_visible): fix issues related to the Firefox css pseudo-element V4#2187
tombrunet merged 2 commits intomain-4.xfrom
dev-2085-v4

Conversation

@shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Feb 5, 2025

  • Rule bug: input_label_visible

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other - Action Artifact

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy marked this pull request as ready for review February 5, 2025 19:05
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in 3.x, Firefox now matches Chrome

@tombrunet tombrunet merged commit 9feb8f0 into main-4.x Feb 10, 2025
16 checks passed
@tombrunet tombrunet deleted the dev-2085-v4 branch February 10, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix(input_label_visible) should not trigger when clipped 0,0,0,0 - different behavior in FF vs Chrome

3 participants