Helm k8s openshift#4764
Merged
Merged
Conversation
fniessink
force-pushed
the
helm-k8s-openshift
branch
from
October 26, 2022 13:06
fd83b1f to
3b1f290
Compare
fniessink
requested changes
Oct 28, 2022
fniessink
left a comment
fniessink
left a comment
Member
There was a problem hiding this comment.
Hi René, thanks again for the PR. I've flagged a few small issues. Also one request, could you add a README in the openshift folder briefly explaining the contents of the folder? Or maybe move the openshift/helm/README.md to openshift/?
zubcevic
force-pushed
the
helm-k8s-openshift
branch
from
November 1, 2022 14:02
7db24c4 to
ccdfabc
Compare
fniessink
force-pushed
the
helm-k8s-openshift
branch
from
November 1, 2022 14:52
a924733 to
ad6714b
Compare
Contributor
Author
|
I think I made all the requested changes. Except for an additional readme since the deployment documentation links to the Readme and each readme refers to the other |
fniessink
force-pushed
the
helm-k8s-openshift
branch
from
November 9, 2022 20:18
c70c299 to
5f89e83
Compare
Member
|
Thank you! |
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
Co-authored-by: Frank Niessink <frank@niessink.com>
fniessink
force-pushed
the
helm-k8s-openshift
branch
from
November 9, 2022 22:07
5f89e83 to
c6df4db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an additional deployment option. It discusses how to use the helm chart for openshift and provides sample for enriching the images with a custom certificate authority and other required changes for a strict rootless and random user id k8s environment