fix(thermoelastic2d): align column names with v1 dataset#247
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns thermoelastic2d v0 problem input/output field names with the v1 HuggingFace dataset schema, so dataset-driven configs and objective columns match simulator/optimizer expectations.
Changes:
- Renamed condition key
volfrac→volume_fraction_targetinThermoElastic2D.ConditionsandFeaModel.run()boundary-condition parsing. - Renamed objective/result key
volume_fraction→volume_fraction_erroracross objectives and returned result dicts. - Updated the 2D FEA model’s example
bcsto use the new key name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| engibench/problems/thermoelastic2d/v0.py | Updates objective name and condition field to match v1 dataset columns; updates simulate() to read the renamed result key. |
| engibench/problems/thermoelastic2d/model/fea_model.py | Updates expected BC key and returned result dict key to match v1 dataset columns; updates local __main__ example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rename `volfrac` → `volume_fraction_target` in Conditions and fea_model, and `volume_fraction` → `volume_fraction_error` in objectives and return dicts to match the thermoelastic_2d_v1 HuggingFace dataset schema. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6383f3a to
4e1f1de
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
volfrac→volume_fraction_targetinConditionsdataclass andfea_model.pyto match the v1 HuggingFace dataset column namevolume_fraction→volume_fraction_errorin objectives tuple and allfea_model.pyreturn dicts to match the v1 datasetTest plan
conditions_keysall exist inthermoelastic_2d_v1dataset columnsobjectivesnames all exist inthermoelastic_2d_v1dataset columnssimulate()successfully on a random design from the datasetoptimize()successfully withmax_iter=5🤖 Generated with Claude Code