This repository was archived by the owner on Mar 29, 2021. It is now read-only.
Conversation
| * @returns {Boolean} | ||
| */ | ||
| var correctServer = function(href, isWorld) { | ||
| return (!href.match ( 'serverid=2' )) === !isWorld; |
Contributor
There was a problem hiding this comment.
[jshint]
- Confusing use of '!'.
w20k
reviewed
Apr 11, 2017
| * @param {Boolean} isWorld | ||
| * @returns {Boolean} | ||
| */ | ||
| var correctServer = function(href, isWorld) { |
Collaborator
There was a problem hiding this comment.
Could you revize this method "correctServer"? :)
Why do you "return !isWorld;" and than do the invert again? Maybe I'm missing something.
Member
Author
There was a problem hiding this comment.
is world contains the boolean if it's meant to be the worldserver, so if the link matches the serverid=2 part, the boolean equals the question if it's the correct server.
If the string does not match the serverid, it's not the worldserver, so it needs to be inverted.
Collaborator
There was a problem hiding this comment.
But you don't test for the setting value? You don't know if it's true or false?
Member
Author
|
done with fixing weird stuff now i think, @w20k |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
more control for notifications