fixes #317 by Idrinth · Pull Request #320 · IDotD/Userscript

Idrinth · 2017-05-02T09:48:01Z

and fixes some formatting in the readme :P

IdrinthGitbot · 2017-05-02T13:39:41Z

+                    parseInt(idrinth.chat.chatRank[chatId][userId], 10)
+                  ],
+                content: (usedPlatforms === ""
+                  ? ""


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:42Z

+        var translation = idrinth.text.get(node.label);
+        return {
+          content: translation === idrinth.text.data.default
+            ? node.label


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:42Z

+            {
+              type: "label",
+              content: translation === idrinth.text.data.default
+                ? label


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:42Z

+                }
+              ],
+              content: translation === idrinth.text.data.default
+                ? label


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:43Z

+          (idrinth.settings.get("moveLeft") ? " left-sided" : "") +
+          (chat.getElementsByClassName("new-message") &&
+            chat.getElementsByClassName("new-message").length
+            ? " new-message"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:43Z

+      isStatic
+    ) {
+      var server = isStatic
+        ? "static"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:43Z

+          } catch (e) {
+            idrinth.core.log(
+              typeof e.getMessage === "function"
+                ? e.getMessage()


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:44Z

+        idrinth.core.multibind.events[event] = idrinth.core.multibind.events[
+          event
+        ]
+          ? idrinth.core.multibind.events[event]


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:44Z

+          : {};
+        idrinth.core.multibind.events[event][selector] = idrinth.core.multibind
+          .events[event][selector]
+          ? idrinth.core.multibind.events[event][selector]


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:44Z

+              "hash=" +
+              data.hash +
+              (idrinth.settings.get("isWorldServer")
+                ? "&" + tag + "serverid=" + 2


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:45Z

+        document.getElementById(
+          "idrinth-stats-" + key
+        ).parentNode.parentNode.childNodes[2].innerHTML = result[key] < 0
+          ? result[key]


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:45Z

+            idrinth.tier.list[listKey].os[difficulty],
+            idrinth.tier.list[listKey][difficulty][ic]
+          )
+            ? "is-os"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:46Z

+      return idrinth.ui.buildElement({
+        css: "idrinth-line" +
+          (config.platforms && !inArray(idrinth.platform, config.platforms)
+            ? " idrinth-hide"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:47Z

+            type: "label",
+            css: "idrinth-float-half",
+            content: translation === idrinth.text.data.default
+              ? config.label


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:47Z

+  openCloseSettings: function() {
+    var toRemove = [
+      idrinth.ui.controls.getAttribute("class").match(/(^|\s)inactive($|\s)/)
+        ? "inactive"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:47Z

+          typeof value === "object" &&
+          Array.isArray(value) &&
+          value !== null
+          ? value


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:48Z

+          : [];
+      };
+      var original = classString === null
+        ? []


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:48Z

+            return {
+              css: "idrinth-float-half" +
+                (platform && platform !== idrinth.platform
+                  ? " idrinth-hide"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:48Z

+                ),
+                buttonMaker(
+                  idrinth.settings.get("alarmActive")
+                    ? idrinth.text.get("button.disableTimedAutoJoin")


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:49Z

+                            label +
+                            "'," +
+                            (isCheck
+                              ? "this.checked"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:49Z

+                "class",
+                "traffic " +
+                  (data.amount < 90
+                    ? "yes"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:49Z

+            element.getElementsByTagName("td")[
+              0
+            ].firstChild.innerHTML = data.amount < 90
+              ? "yes"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:50Z

+                    type: "td",
+                    css: "traffic " +
+                      (data.amount < 90
+                        ? "yes"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T13:39:50Z

+                      {
+                        type: "span",
+                        content: data.amount < 90
+                          ? "yes"


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

Idrinth · 2017-05-02T13:43:00Z

bots seem to slightly disagree on the formatting, @w20k @Ardenian :D

w20k · 2017-05-02T14:56:31Z

It's here - the bot war :D

IdrinthGitbot · 2017-05-02T15:07:14Z

-
-    /*
+    return toE === 1 || (toE && (dp <= i || i <= Big.E_NEG))
+      ? // Exponential notation.


[jshint]

Misleading line break before '?'; readers may interpret this as an expression boundary.

IdrinthGitbot · 2017-05-02T15:07:14Z

+        for (; ++xc[i] > 9; ) {
+          xc[i] = 0;
+
+          if (!i--) {


[jshint]

Bad operand.

IdrinthGitbot · 2017-05-02T15:17:50Z

+          },
+          1000
+        );
+        delete idrinth["start"];


[jshint]

['start'] is better written in dot notation.

Idrinth · 2017-05-02T16:04:11Z

@w20k @Ardenian I guess we should turn off sideci? I can't find a way to configure jshint to work well with prettier's code

w20k · 2017-05-02T16:05:39Z

Yeah, shut it down.

Idrinth · 2017-05-02T16:07:50Z

done, will test it a bit tonight, just to make sure it still works

should make sure that our JSON-lanf doesn't break

Idrinth · 2017-05-02T20:37:19Z

works, @w20k - no omplaints from you I assume?

w20k · 2017-05-03T05:45:09Z

Nope, nothing so far :)

w20k · 2017-05-03T05:45:44Z

LGTM

![Approved with PullApprove](https://img.shields.io/badge/Javascript Reviewers-approved-brightgreen.svg)

Idrinth and others added 5 commits May 2, 2017 11:47

fixes #317

2375506

and fixes some formatting in the readme :P

Update README.md

e987fd8

Update README.md

04a73ef

Update landbuy.js

15fd3cb

prettyfiing branch

95ad9a9

IdrinthGitbot reviewed May 2, 2017

View reviewed changes

modifiing iife to match prettier (outside->inside)

c49f04c

IdrinthGitbot reviewed May 2, 2017

View reviewed changes

Comment thread src/libs/big.js

for (; ++xc[i] > 9; ) {

xc[i] = 0;

if (!i--) {

Copy link
Copy Markdown

Contributor

IdrinthGitbot May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[jshint]

Bad operand.

Create .jshintignore

83ef421

IdrinthGitbot reviewed May 2, 2017

View reviewed changes

adding prettier ignore

a993e28

should make sure that our JSON-lanf doesn't break

w20k merged commit 02e1ea5 into master May 3, 2017

Idrinth deleted the Idrinth-patch-1 branch May 3, 2017 07:36

Conversation

Idrinth commented May 2, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Idrinth commented May 2, 2017

Uh oh!

w20k commented May 2, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Idrinth commented May 2, 2017

Uh oh!

w20k commented May 2, 2017

Uh oh!

Idrinth commented May 2, 2017

Uh oh!

Idrinth commented May 2, 2017

Uh oh!

w20k commented May 3, 2017

Uh oh!

w20k commented May 3, 2017 • edited by Idrinth Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

w20k commented May 3, 2017 •

edited by Idrinth

Loading