Conversation
|
This structure makes sense to me |
Collaborator
Author
|
@GregoryHorvath do you mind giving this a quick review + merge? |
a8b49bb to
e653761
Compare
Collaborator
Author
|
Would be great to get it up on staging as well. Thank you @GregoryHorvath! |
Collaborator
|
@geohacker we'd need to check up on failing tests here :( |
Collaborator
It seems the migrations conflict. Just run |
Collaborator
Author
|
Ok cool I can do that. Wasn't sure the best approach with migrations! |
Collaborator
Author
|
@GregoryHorvath @batpad thank you, I just merged the migrations and tests pass. 👍 |
Collaborator
Author
|
Ping @GregoryHorvath @batpad |
Collaborator
|
@geohacker So sorry I was about to deploy this but got distracted and forgot about it since. Merging it and deploying it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses IFRCGo/go-frontend#1009
Changes
/event/:id
/event_snippets
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.
cc @necoline @batpad @GregoryHorvath