This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Conversation
Contributor
|
Should we render all tab header and panels (aside from the default tab) in a child component? |
Collaborator
Author
|
@necoline I'm a bit hesitant to rework this into child components. I tried real quick and the way Tabs are defined in a TabsList etc seem a bit tricky to get right if we pull into child components. I just added a 0 set timeout after the tabs are registered and that seem to work well for users arriving at invalid hashes. I don't love this approach, but if you can think of better a way let's do that. Thanks! cc @batpad |
geohacker
force-pushed
the
feature/multiple-tabs
branch
from
9a3d44e to
e8eff13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1009. Should be merged after IFRCGo/go-api#650
@necoline - let me know what you think, I think the way I'm managing the tabs in the state could probably be more elegant.
One thing I'm struggling with which we should absolutely fix is this: https://github.com/IFRCGo/go-frontend/blob/feature/multiple-tabs/app/assets/scripts/views/emergency.js#L116 -- if we do this on componentDidMount, the tabs aren't populated yet so it always resolves to
#details.cc @batpad