fix: increase database to GP_Standard_D4ds_v5

[thenav56]

Continue of #216

[thenav56]

Plan:

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # module.resources.azurerm_postgresql_flexible_server.montandon_eoapi will be updated in-place
  ~ resource "azurerm_postgresql_flexible_server" "montandon_eoapi" {
        id                            = "/subscriptions/39308fb0-9929-4b29-aafa-b3c78a8b0658/resourceGroups/ifrctgo002rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/montandon-eoapi-staging-psql-flexible-server"
        name                          = "montandon-eoapi-staging-psql-flexible-server"
      ~ sku_name                      = "GP_Standard_D2ds_v5" -> "GP_Standard_D4ds_v5"
        tags                          = {}
        # (16 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.resources.azurerm_postgresql_flexible_server_configuration.montandon_eoapi_postgres_config["shared_buffers"] will be created
  + resource "azurerm_postgresql_flexible_server_configuration" "montandon_eoapi_postgres_config" {
      + id        = (known after apply)
      + name      = "shared_buffers"
      + server_id = "/subscriptions/39308fb0-9929-4b29-aafa-b3c78a8b0658/resourceGroups/ifrctgo002rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/montandon-eoapi-staging-psql-flexible-server"
      + value     = "4194304"
    }

  # module.resources.azurerm_postgresql_flexible_server_configuration.montandon_eoapi_postgres_config["work_mem"] will be created
  + resource "azurerm_postgresql_flexible_server_configuration" "montandon_eoapi_postgres_config" {
      + id        = (known after apply)
      + name      = "work_mem"
      + server_id = "/subscriptions/39308fb0-9929-4b29-aafa-b3c78a8b0658/resourceGroups/ifrctgo002rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/montandon-eoapi-staging-psql-flexible-server"
      + value     = "65536"
    }

Plan: 2 to add, 1 to change, 0 to destroy.

Plan looks good, @pantierra @batpad can you also confirm? Then we can go ahead with the merge.

Note

For this we will need to push to master branch for the production changes.

[thenav56]

Also, we might have an issue with shared_buffers value

Postgres stores shared_buffers internally in blocks, where a block is BLCKSZ = 8 kB in every standard build. Resulting size will be 32 GiB which is 2 times the instance memory when shared_buffers = "4194304" is used

[thenav56]

Plan is good.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # module.resources.azurerm_postgresql_flexible_server.montandon_eoapi will be updated in-place
  ~ resource "azurerm_postgresql_flexible_server" "montandon_eoapi" {
        id                            = "/subscriptions/39308fb0-9929-4b29-aafa-b3c78a8b0658/resourceGroups/ifrctgo002rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/montandon-eoapi-staging-psql-flexible-server"
        name                          = "montandon-eoapi-staging-psql-flexible-server"
      ~ sku_name                      = "GP_Standard_D2ds_v5" -> "GP_Standard_D4ds_v5"
        tags                          = {}
        # (16 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.resources.azurerm_postgresql_flexible_server_configuration.montandon_eoapi_postgres_config["shared_buffers"] will be created
  + resource "azurerm_postgresql_flexible_server_configuration" "montandon_eoapi_postgres_config" {
      + id        = (known after apply)
      + name      = "shared_buffers"
      + server_id = "/subscriptions/39308fb0-9929-4b29-aafa-b3c78a8b0658/resourceGroups/ifrctgo002rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/montandon-eoapi-staging-psql-flexible-server"
      + value     = "524288"
    }

  # module.resources.azurerm_postgresql_flexible_server_configuration.montandon_eoapi_postgres_config["work_mem"] will be created
  + resource "azurerm_postgresql_flexible_server_configuration" "montandon_eoapi_postgres_config" {
      + id        = (known after apply)
      + name      = "work_mem"
      + server_id = "/subscriptions/39308fb0-9929-4b29-aafa-b3c78a8b0658/resourceGroups/ifrctgo002rg/providers/Microsoft.DBforPostgreSQL/flexibleServers/montandon-eoapi-staging-psql-flexible-server"
      + value     = "65536"
    }

I will merge this in few minutes

[thenav56]

@szabozoltan69 @pantierra @batpad This has been applied to the staging instance (~ 13 min). Can you check?

[thenav56]

All applied

❯ az postgres flexible-server parameter list \                                                                                                                                                                
  --subscription 39308fb0-9929-4b29-aafa-b3c78a8b0658 \
  --resource-group ifrctgo002rg \
  --server-name montandon-eoapi-staging-psql-flexible-server \
  --query "[?name=='shared_buffers'||name=='work_mem'].{name:name,value:value,default:defaultValue,unit:unit,source:source,dynamic:isDynamicConfig,pendingRestart:isConfigPendingRestart}" \
  -o table
Name            Value    Default    Unit    Source          Dynamic    PendingRestart
--------------  -------  ---------  ------  --------------  ---------  ----------------
shared_buffers  524288   524288     8kB     system-default  False      False
work_mem        65536    4096       kB      user-override   True       False

❯ az postgres flexible-server show \                                                                                                                                                                          
  --subscription 39308fb0-9929-4b29-aafa-b3c78a8b0658 \
  --resource-group ifrctgo002rg \
  --name montandon-eoapi-staging-psql-flexible-server \
  --query "{sku:sku.name,tier:sku.tier,storage:storage.storageSizeGb,tier2:storage.tier,iops:storage.iops,ha:highAvailability.mode}" -o jsonc
{
  "ha": "Disabled",
  "iops": 1100,
  "sku": "Standard_D4ds_v5",
  "storage": 256,
  "tier": "GeneralPurpose",
  "tier2": "P15"
}

[batpad]

@wrynearson - from @thenav56 's earlier comment: this has only been applied on staging. Have you been doing your tests against staging or prod?

[wrynearson]

Apologies, I missed that message. @pantierra on Slack debugged and deemed that this worked well.

[wrynearson]

@thenav56 I think this can also be deployed to prod (no need to rush today though). cc @pantierra