Conversation
added 3 commits
February 16, 2026 14:05
azaroth42
requested review from
JulieWinchester,
kirschbombe,
mikeapp,
mixterj and
tomcrane
tomcrane
approved these changes
Feb 17, 2026
Contributor
tomcrane
left a comment
tomcrane
left a comment
There was a problem hiding this comment.
Maybe an additional sentence in index.md where List is used just calling it out (and referring the reader to the model docs)
mikeapp
reviewed
Feb 17, 2026
source/presentation/4.0/index.md
Outdated
| "target": ["https://example.org/iiif/presentation/examples/manifest-with-containers/canvas"] | ||
| }, | ||
| "target": { | ||
| "id": "https://example.org/iiif/presentation/examples/manifest-with-containers/canvas". |
Member
There was a problem hiding this comment.
needs a comma (? diff shows a deleted period at the end of the line)
mikeapp
reviewed
Feb 17, 2026
source/presentation/4.0/index.md
Outdated
| ] | ||
| }, | ||
| "target": "https://example.org/iiif/presentation/examples/manifest-composite-two-canvases/canvas/c1#xywh=0,0,300,300" | ||
| "target": {} |
mikeapp
approved these changes
Feb 17, 2026
tomcrane
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #2426 discussion, change
bodyandtargetto be a single JSON object. If there's multiple, then wrap in an aggregate construction (Composite, List, Independents, Choice).I think this is significantly cleaner than singleton arrays 99% of the time.
(Thanks to @stephenwf!)