i18n: finish translations for de, fr, it, es variants#1446
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR finalizes translations in six locale files (de_DE, es_AR, es_ES, es_MX, fr_FR, it) for the ConfigDialog SSH_AUTH_SOCK override: UI label/description, path validation errors, and the multi-line invalid-override warning. ChangesSSH_AUTH_SOCK Override Localization Completion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@localization/localization_fr_FR.ts`:
- Around line 317-318: Several translated validation messages in
localization_fr_FR.ts are still marked with type="unfinished" (e.g., the
translation element containing "Le chemin n'existe pas." and the other
translations at the ranges noted). Edit those <translation> elements and remove
the attribute type="unfinished" for each translated string (including the
entries around the specified ranges 317-318, 322-323, 327-328, 332-333, 341-346)
so the translations are treated as finalized; ensure you only remove the
attribute and do not alter the translation text itself.
In `@localization/localization_it.ts`:
- Around line 432-433: Remove the type="unfinished" attribute from the completed
Italian translation entries for the SSH_AUTH_SOCK validation messages so they
are treated as finalized; specifically edit the <translation> elements
associated with the SSH_AUTH_SOCK validation strings (the entries referenced
around the shown snippet and the other occurrences noted) and delete the
type="unfinished" attribute while keeping the existing Italian text intact.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: ab6b4948-6ad9-4ee0-b42f-3bc9d8567588
📒 Files selected for processing (6)
localization/localization_de_DE.tslocalization/localization_es_AR.tslocalization/localization_es_ES.tslocalization/localization_es_MX.tslocalization/localization_fr_FR.tslocalization/localization_it.ts
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 2 file(s) based on 2 unresolved review comments. A stacked PR containing fixes has been created.
Time taken: |
Fixed 2 file(s) based on 2 unresolved review comments. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Summary
Part of finishing i18n coverage for the SSH_AUTH_SOCK auto-probe + override feature (PR #1438).
Summary by CodeRabbit