Skip to content

i18n: finish translations for de, fr, it, es variants#1446

Merged
annejan merged 2 commits into
mainfrom
i18n/de-fr-it-es
May 9, 2026
Merged

i18n: finish translations for de, fr, it, es variants#1446
annejan merged 2 commits into
mainfrom
i18n/de-fr-it-es

Conversation

@nogeenhenk
Copy link
Copy Markdown
Contributor

@nogeenhenk nogeenhenk commented May 9, 2026

Summary

  • de_DE: Marked all 8 SSH_AUTH_SOCK translations as finished
  • fr_FR: Marked first 3 UI strings as finished, added 5 validation translations
  • it: Marked first 3 UI strings as finished, added 5 validation translations
  • es_ES, es_AR, es_MX: Marked all 8 SSH_AUTH_SOCK translations as finished (preserving regional wording differences: "sustituir" vs "suplantar" vs "sobrescribir")

Part of finishing i18n coverage for the SSH_AUTH_SOCK auto-probe + override feature (PR #1438).

Summary by CodeRabbit

  • Localization
    • Completed and refined translations for the SSH_AUTH_SOCK override label, helper text, and related validation/warning messages in German, French, Italian, and Spanish (ES, AR, MX), improving clarity in the configuration dialog and validation feedback.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 806485d1-a24d-4fb7-86d2-69293144a285

📥 Commits

Reviewing files that changed from the base of the PR and between 47d488f and 78e80ac.

📒 Files selected for processing (2)
  • localization/localization_fr_FR.ts
  • localization/localization_it.ts

📝 Walkthrough

Walkthrough

This PR finalizes translations in six locale files (de_DE, es_AR, es_ES, es_MX, fr_FR, it) for the ConfigDialog SSH_AUTH_SOCK override: UI label/description, path validation errors, and the multi-line invalid-override warning.

Changes

SSH_AUTH_SOCK Override Localization Completion

Layer / File(s) Summary
UI Labels and Descriptions
localization/localization_de_DE.ts, localization/localization_es_AR.ts, localization/localization_es_ES.ts, localization/localization_es_MX.ts, localization/localization_fr_FR.ts, localization/localization_it.ts
Completes SSH_AUTH_SOCK override UI label, description, and auto-probe hint translations across all six locale files; removes type="unfinished" markers.
Path Validation Messages
localization/localization_de_DE.ts, localization/localization_es_AR.ts, localization/localization_es_ES.ts, localization/localization_es_MX.ts, localization/localization_fr_FR.ts, localization/localization_it.ts
Completes translations for path validation errors (path does not exist, not readable, not a Unix domain socket) and the "potentially invalid SSH_AUTH_SOCK override" headline across locales.
Invalid Override Warning
localization/localization_de_DE.ts, localization/localization_es_AR.ts, localization/localization_es_ES.ts, localization/localization_es_MX.ts, localization/localization_fr_FR.ts, localization/localization_it.ts
Completes the multi-line warning that the entered override may be invalid but will still be saved; preserves %1 placeholders and explanatory text across locales.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • IJHack/QtPass#1441: Related updates to SSH_AUTH_SOCK override translation strings across locales.
  • IJHack/QtPass#1444: Overlapping localization updates for SSH_AUTH_SOCK override and ConfigDialog messages.
  • IJHack/QtPass#1438: Introduced SSH_AUTH_SOCK override strings that these translations finalize.

Suggested labels

size:XS

Poem

🐰 I hopped through strings in six-fold rhyme,
Finished lines for sockets and time,
From Deutsch to Español and Français delight,
Italian notes now read just right,
Translations snug, the UI's bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: completing translations for German, French, Italian, and Spanish variants for SSH_AUTH_SOCK-related strings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch i18n/de-fr-it-es

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@localization/localization_fr_FR.ts`:
- Around line 317-318: Several translated validation messages in
localization_fr_FR.ts are still marked with type="unfinished" (e.g., the
translation element containing "Le chemin n'existe pas." and the other
translations at the ranges noted). Edit those <translation> elements and remove
the attribute type="unfinished" for each translated string (including the
entries around the specified ranges 317-318, 322-323, 327-328, 332-333, 341-346)
so the translations are treated as finalized; ensure you only remove the
attribute and do not alter the translation text itself.

In `@localization/localization_it.ts`:
- Around line 432-433: Remove the type="unfinished" attribute from the completed
Italian translation entries for the SSH_AUTH_SOCK validation messages so they
are treated as finalized; specifically edit the <translation> elements
associated with the SSH_AUTH_SOCK validation strings (the entries referenced
around the shown snippet and the other occurrences noted) and delete the
type="unfinished" attribute while keeping the existing Italian text intact.
🪄 Autofix (Beta)

✅ Autofix completed


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: ab6b4948-6ad9-4ee0-b42f-3bc9d8567588

📥 Commits

Reviewing files that changed from the base of the PR and between 2fe112d and 47d488f.

📒 Files selected for processing (6)
  • localization/localization_de_DE.ts
  • localization/localization_es_AR.ts
  • localization/localization_es_ES.ts
  • localization/localization_es_MX.ts
  • localization/localization_fr_FR.ts
  • localization/localization_it.ts

Comment thread localization/localization_fr_FR.ts Outdated
Comment thread localization/localization_it.ts Outdated
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 2 file(s) based on 2 unresolved review comments.

A stacked PR containing fixes has been created.

  • Stacked PR: #1448
  • Files modified:
  • localization/localization_fr_FR.ts
  • localization/localization_it.ts

Time taken: 1m 29s

Fixed 2 file(s) based on 2 unresolved review comments.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants