Skip to content

i18n: finish SSH_AUTH_SOCK translations for mr, nb, fa, pt_BR, pt_PT#1453

Merged
annejan merged 1 commit into
mainfrom
i18n/finish-5-locales-sshsock
May 9, 2026
Merged

i18n: finish SSH_AUTH_SOCK translations for mr, nb, fa, pt_BR, pt_PT#1453
annejan merged 1 commit into
mainfrom
i18n/finish-5-locales-sshsock

Conversation

@nogeenharrie
Copy link
Copy Markdown
Contributor

@nogeenharrie nogeenharrie commented May 9, 2026

Summary

Finishes the 8 unfinished SSH_AUTH_SOCK-related translations (from PR #1438) for 5 locales, bringing them all to 100%.

Changes per locale

  • Norwegian Bokmål (nb): 318/318 — full translation of all 8 strings
  • Portuguese (Brazil) (pt_BR): 358/358 — full translation of all 8 strings
  • Portuguese (Portugal) (pt_PT): 357/357 — full translation of all 8 strings
  • Marathi (mr): 314/314 — filled 4 empty strings (path errors, validation), marked existing 3 as complete
  • Persian (fa): 314/314 — filled 4 empty strings, marked existing 3 as complete

All translations marked as finished (non-unfinished) — ready for Weblate review.

Summary by CodeRabbit

  • Localization
    • Completed full language translations for Persian, Marathi, Norwegian, and Portuguese (Brazilian and European) variants
    • Finalized UI text and descriptions for SSH authentication socket override configuration options
    • Added comprehensive translations for validation error messages and configuration feedback related to SSH settings
    • All users in these languages now have complete, consistent localization throughout the application

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

📝 Walkthrough

Walkthrough

This PR completes previously unfinished translations for SSH_AUTH_SOCK override configuration across five localization files: Persian, Marathi, Norwegian, and Portuguese (Brazil and Portugal). The translations cover the override UI label/description, path validation error messages, and a multi-line warning about potentially invalid override values.

Changes

SSH_AUTH_SOCK Override Localization Completion

Layer / File(s) Summary
SSH_AUTH_SOCK Override UI Text
localization/localization_fa.ts, localization/localization_mr.ts, localization/localization_nb.ts, localization/localization_pt_BR.ts, localization/localization_pt_PT.ts
Override label, optional path description, and auto-probe via gpgconf note are translated in all five language files, replacing type="unfinished" entries with finalized text.
Path Validation Error Messages
localization/localization_fa.ts, localization/localization_mr.ts, localization/localization_nb.ts, localization/localization_pt_BR.ts, localization/localization_pt_PT.ts
ConfigDialog validation messages for path does not exist, path not readable, path not a Unix domain socket, and "Potentially invalid SSH_AUTH_SOCK override" warning are translated in all five languages.
Invalid Override Warning Message
localization/localization_fa.ts, localization/localization_mr.ts, localization/localization_pt_BR.ts, localization/localization_pt_PT.ts
Multi-line warning explaining that the override value may be invalid but will still be saved (including %1 placeholder) is translated in four language files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • IJHack/QtPass#1450: Completes the same SSH_AUTH_SOCK override and ConfigDialog validation translations in different language files.
  • IJHack/QtPass#1443: Updates the same SSH_AUTH_SOCK override UI and ConfigDialog validation translations, filling previously unfinished translation strings.
  • IJHack/QtPass#1439: Introduces the SSH_AUTH_SOCK override feature and ConfigDialog validation messages that this PR localizes.

Suggested labels

size:S

Poem

🐰 Five tongues now speak of sockets true,
Where SSH dances through and through,
From Persian prose to Norwegian song,
Brazilian warmth and Portuguese throng,
No more unfinished, complete at last!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: completing SSH_AUTH_SOCK translations for five specific locales (mr, nb, fa, pt_BR, pt_PT).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch i18n/finish-5-locales-sshsock

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
localization/localization_mr.ts (1)

462-477: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix Marathi typo in “invalid” wording (अवैदअवैध).

Line 464 and Line 473 use अवैद, which appears to be a typo in user-facing error/warning text.

Suggested fix
-        <translation>संभाव्य अवैद SSH_AUTH_SOCK ओव्हरराइड</translation>
+        <translation>संभाव्य अवैध SSH_AUTH_SOCK ओव्हरराइड</translation>
-        <translation>SSH_AUTH_SOCK ओव्हरराइड मूल्य अवैद असू शकते.
+        <translation>SSH_AUTH_SOCK ओव्हरराइड मूल्य अवैध असू शकते.
As per coding guidelines, "Fix translation bugs directly in `.ts` files for placeholder mismatches, broken HTML tags, and mixed-script artifacts; fill empty entries with best-effort translations marked `type=\"unfinished\"`."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@localization/localization_mr.ts` around lines 462 - 477, Replace the
misspelled Marathi word "अवैद" with the correct "अवैध" in the translation
entries that map to the source "Potentially invalid SSH_AUTH_SOCK override" and
the longer source starting "The SSH_AUTH_SOCK override value may be invalid."
(these are the translation strings currently containing "अवैद"); update both
occurrences in localization_mr.ts so the user-facing messages read "अवैध"
instead of "अवैद".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@localization/localization_mr.ts`:
- Around line 462-477: Replace the misspelled Marathi word "अवैद" with the
correct "अवैध" in the translation entries that map to the source "Potentially
invalid SSH_AUTH_SOCK override" and the longer source starting "The
SSH_AUTH_SOCK override value may be invalid." (these are the translation strings
currently containing "अवैद"); update both occurrences in localization_mr.ts so
the user-facing messages read "अवैध" instead of "अवैद".

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 943588fd-96af-458a-96cd-e5ecf89c81c9

📥 Commits

Reviewing files that changed from the base of the PR and between d46bc28 and dead871.

📒 Files selected for processing (5)
  • localization/localization_fa.ts
  • localization/localization_mr.ts
  • localization/localization_nb.ts
  • localization/localization_pt_BR.ts
  • localization/localization_pt_PT.ts

@annejan annejan merged commit 4c21535 into main May 9, 2026
21 of 22 checks passed
@annejan annejan deleted the i18n/finish-5-locales-sshsock branch May 9, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants