Skip to content

i18n: finish translations for pa_IN, ro, sr_RS, sr_Cyrl#1454

Merged
annejan merged 3 commits into
mainfrom
i18n/pa-in-ro-sr
May 9, 2026
Merged

i18n: finish translations for pa_IN, ro, sr_RS, sr_Cyrl#1454
annejan merged 3 commits into
mainfrom
i18n/pa-in-ro-sr

Conversation

@nogeenhenk
Copy link
Copy Markdown
Contributor

@nogeenhenk nogeenhenk commented May 9, 2026

Summary

  • pa_IN (Punjabi): Added all 8 SSH_AUTH_SOCK translations (marked type="unfinished" for Weblate review)
  • ro (Romanian): Added all 8 SSH_AUTH_SOCK translations (marked type="unfinished" for Weblate review)
  • sr_RS (Serbian Latin): Added all 8 SSH_AUTH_SOCK translations (marked type="unfinished" for Weblate review)
  • sr_Cyrl (Serbian Cyrillic): Added all 8 SSH_AUTH_SOCK translations (marked type="unfinished" for Weblate review)

Part of finishing i18n coverage for the SSH_AUTH_SOCK auto-probe + override feature (PR #1438).

Summary by CodeRabbit

  • Localization
    • Completed Punjabi (India), Romanian, Serbian (Cyrillic) and Serbian (Latin) translations for the SSH agent override in settings: label, help text (including auto-probe hint), and all related validation, error and multi-line warning messages to improve multilingual UI clarity.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 994ff679-0fa8-4103-bf3f-2ee0d9614e37

📥 Commits

Reviewing files that changed from the base of the PR and between f88a569 and 0571216.

📒 Files selected for processing (1)
  • localization/localization_sr_Cyrl.ts

📝 Walkthrough

Walkthrough

Four locale .ts files are updated to add translations for the SSH_AUTH_SOCK override UI label/help text, path validation error messages, and the override warning/multiline info used by ConfigDialog.

Changes

SSH_AUTH_SOCK Localization Completion

Layer / File(s) Summary
SSH_AUTH_SOCK UI Label and Help Text Translations
localization/localization_pa_IN.ts, localization/localization_ro.ts, localization/localization_sr_Cyrl.ts, localization/localization_sr_RS.ts
UI label, optional-path help text, and auto-probe hint translations are added across all four language files for the SSH_AUTH_SOCK override configuration field.
Path Validation Error Message Translations
localization/localization_pa_IN.ts, localization/localization_ro.ts, localization/localization_sr_Cyrl.ts, localization/localization_sr_RS.ts
Error messages for path validation (path missing, not readable, not a Unix domain socket) are translated in all four language files.
SSH_AUTH_SOCK Override Warning and Info Translations
localization/localization_pa_IN.ts, localization/localization_ro.ts, localization/localization_sr_Cyrl.ts, localization/localization_sr_RS.ts
Warnings for potentially invalid overrides and the multi-line message indicating an invalid value will still be saved are translated across all four language files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • IJHack/QtPass#1459: Same SSH_AUTH_SOCK override strings translated for other locales.
  • IJHack/QtPass#1452: Completes ConfigDialog SSH_AUTH_SOCK translations in additional locale files.
  • IJHack/QtPass#1453: Adds translations for the same SSH_AUTH_SOCK override and validation strings in other languages.

Poem

🐰 I hopped through texts in four small lands,
Patching labels, hints, and careful hands.
Paths and warnings, placeholders true —
Now messages speak in languages new.
A rabbit's stitch: translations through.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the pull request's primary change: completing translations for four locales (pa_IN, ro, sr_RS, sr_Cyrl) for SSH_AUTH_SOCK-related strings in the configuration UI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch i18n/pa-in-ro-sr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@localization/localization_sr_Cyrl.ts`:
- Around line 159-160: Update the Serbian Cyrillic translation for the string
whose source is "Optional path to override SSH_AUTH_SOCK. Leave empty to
auto-probe via gpgconf (issue `#543`)." — replace "измена `#543`" with "issue `#543`"
(or the Serbian term for an issue/ticket such as "прикључак/проблем `#543`" if you
prefer a localized noun) in the translation value so it preserves the original
"issue `#543`" meaning; edit the translation entry in localization_sr_Cyrl.ts
corresponding to that source text.

In `@localization/localization_sr_RS.ts`:
- Around line 163-165: The Serbian translation changed the semantic of the issue
reference: update the <translation> for the message whose <source> is "Optional
path to override SSH_AUTH_SOCK. Leave empty to auto-probe via gpgconf (issue
`#543`)." so that "(izmena `#543`)" is replaced with the correct equivalent
"(problem `#543`)" or "(issue `#543`)" in Serbian (e.g., "(problem `#543`)" or "(issue
`#543`)"), keep type="unfinished" as per guidelines, and ensure no other text or
placeholders are altered; edit the <translation> element in
localization_sr_RS.ts for that message only.
🪄 Autofix (Beta)

✅ Autofix completed


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 10ea816e-e324-494d-ac1c-b8f9a7b77678

📥 Commits

Reviewing files that changed from the base of the PR and between 4c21535 and 4e72511.

📒 Files selected for processing (4)
  • localization/localization_pa_IN.ts
  • localization/localization_ro.ts
  • localization/localization_sr_Cyrl.ts
  • localization/localization_sr_RS.ts

Comment thread localization/localization_sr_Cyrl.ts Outdated
Comment thread localization/localization_sr_RS.ts
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 2 file(s) based on 2 unresolved review comments.

Files modified:

  • localization/localization_sr_Cyrl.ts
  • localization/localization_sr_RS.ts

Commit: f88a5692a345b17d93cbb373f4d918dd19dd805d

The changes have been pushed to the i18n/pa-in-ro-sr branch.

Time taken: 1m 24s

Fixed 2 file(s) based on 2 unresolved review comments.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@localization/localization_sr_Cyrl.ts`:
- Around line 414-415: Update the translation for the source string "The path is
not a Unix domain socket." by replacing the current value "Путања није Unix
домен сокет." with the clearer technical Serbian phrasing "Путања није Unix
доменска утичница." and keep the translation attribute type="unfinished" per
guidelines; locate the <translation> element corresponding to that exact
<source> to make the change.
🪄 Autofix (Beta)

✅ Autofix completed


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: c49a8a5d-31d4-4655-9638-addd3f3c10c7

📥 Commits

Reviewing files that changed from the base of the PR and between 4e72511 and f88a569.

📒 Files selected for processing (2)
  • localization/localization_sr_Cyrl.ts
  • localization/localization_sr_RS.ts

Comment thread localization/localization_sr_Cyrl.ts Outdated
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

  • localization/localization_sr_Cyrl.ts

Commit: 057121673a218025828e87f553053a9af824f7e2

The changes have been pushed to the i18n/pa-in-ro-sr branch.

Time taken: 56s

Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
@annejan annejan merged commit 56a44a5 into main May 9, 2026
15 of 16 checks passed
@annejan annejan deleted the i18n/pa-in-ro-sr branch May 9, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants