Skip to content

i18n: finish SSH_AUTH_SOCK translations for th, tr, vi; add best-effort for ur#1457

Merged
annejan merged 1 commit into
mainfrom
i18n/finish-4-locales-sshsock-2
May 9, 2026
Merged

i18n: finish SSH_AUTH_SOCK translations for th, tr, vi; add best-effort for ur#1457
annejan merged 1 commit into
mainfrom
i18n/finish-4-locales-sshsock-2

Conversation

@nogeenharrie
Copy link
Copy Markdown
Contributor

@nogeenharrie nogeenharrie commented May 9, 2026

Summary

Finishes the 8 unfinished SSH_AUTH_SOCK-related strings from PR #1438 for 4 more locales.

Locale Before After Status
th (Thai) 97% 314/314 (100%) Finished
tr (Turkish) 97% 325/325 (100%) Finished
vi (Vietnamese) 97% 314/314 (100%) Finished
ur (Urdu) 97% 306/314 (98%) Best-effort, needs Weblate review

Summary by CodeRabbit

  • Localization
    • Completed translations for Thai, Turkish, Urdu, and Vietnamese languages. SSH authentication configuration settings and their validation messages are now fully translated in these languages, providing complete language support for users.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: eea48444-33ad-41d1-aed9-5c3ae6ecfabf

📥 Commits

Reviewing files that changed from the base of the PR and between e5b292b and 1a6544b.

📒 Files selected for processing (4)
  • localization/localization_th.ts
  • localization/localization_tr.ts
  • localization/localization_ur.ts
  • localization/localization_vi.ts

📝 Walkthrough

Walkthrough

Four localization files (Thai, Turkish, Urdu, Vietnamese) complete translations for SSH_AUTH_SOCK override feature strings in ConfigDialog: UI label, description, validation error messages, and invalid value warning. All files follow parallel structure across the same line ranges, replacing previously unfinished entries.

Changes

SSH_AUTH_SOCK Override Localization

Layer / File(s) Summary
UI Label and Description
localization/localization_th.ts, localization/localization_tr.ts, localization/localization_ur.ts, localization/localization_vi.ts
SSH_AUTH_SOCK override label (lines 309–319), optional path description, and (auto-probe via gpgconf) hint are translated into Thai, Turkish, Urdu, and Vietnamese, replacing previously unfinished entries.
Configuration Validation Error Messages
localization/localization_th.ts, localization/localization_tr.ts, localization/localization_ur.ts, localization/localization_vi.ts
Path validation error messages (lines 449–468) for non-existent, unreadable, and non-Unix-domain-socket paths, plus the "potentially invalid override" warning, are translated into all four languages.
Invalid Override Value Warning
localization/localization_th.ts, localization/localization_tr.ts, localization/localization_ur.ts, localization/localization_vi.ts
Multi-line warning (lines 473–477) stating the SSH_AUTH_SOCK override value may be invalid but will still be saved as entered is translated into all four languages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • IJHack/QtPass#1441: Updates SSH_AUTH_SOCK override localization strings in additional language files.
  • IJHack/QtPass#1439: Implements the SSH_AUTH_SOCK override feature and validation messages that these localization strings translate.
  • IJHack/QtPass#1455: Completes SSH_AUTH_SOCK override translations in additional locale files.

Poem

🐰 Four languages dance in harmony true,
Thai, Turkish, Urdu, Vietnamese too,
SSH sockets get their words so fine,
No more unfinished—each message defined! 🌍✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: completing SSH_AUTH_SOCK translations across four locales with specific outcomes for each.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch i18n/finish-4-locales-sshsock-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@annejan annejan merged commit 868ed79 into main May 9, 2026
15 of 16 checks passed
@annejan annejan deleted the i18n/finish-4-locales-sshsock-2 branch May 9, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants