Translations update from Hosted Weblate#1470
Conversation
📝 WalkthroughWalkthroughThis PR updates UI translations for QtPass: extensive Estonian wording and validation refinements, and completes the "That name would resolve outside the password store" validation message in Galician, Polish, Swedish, and Chinese. ChangesLocalization Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@localization/localization_et.ts`:
- Around line 419-422: The Estonian translation for the message with source "The
path does not exist." (message at location ../src/configdialog.cpp line="263")
contains a typo "Aaukohta pole olemas." — update the translation to "Asukohta
pole olemas." in localization_et.ts to correct the spelling.
- Around line 513-516: Update the Estonian translation for the source string
"Failed to create password-store at: %1" by fixing the typo in the translated
text: change "salasõnahoidla loomine ei õnnestunus asukohas: %1" to
"salasõnahoidla loomine ei õnnestunud asukohas: %1" in the localization entry
that corresponds to that source message.
In `@localization/localization_pl.ts`:
- Around line 1270-1273: The Polish translation for the source string "That name
would resolve outside the password store. Please choose a different name." was
altered and lost the original meaning; update the translation in
localization_pl.ts for the message corresponding to mainwindow.cpp (source text
above) so it explicitly conveys that the name would resolve outside the password
store (e.g., include phrasing equivalent to "będzie rozwiązywana poza magazynem
haseł") and keep the second sentence asking to choose a different name; modify
the translation for that <message> entry only so it matches the source intent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f8e7f2b2-be3f-416e-9c7e-db1f024fca10
📒 Files selected for processing (5)
localization/localization_et.tslocalization/localization_gl.tslocalization/localization_pl.tslocalization/localization_sv.tslocalization/localization_zh_CN.ts
| <location filename="../src/configdialog.cpp" line="263"/> | ||
| <source>The path does not exist.</source> | ||
| <translation>Tee ei eksisteeri.</translation> | ||
| <translation>Aaukohta pole olemas.</translation> | ||
| </message> |
There was a problem hiding this comment.
Fix typo in path validation message (Line 421).
Aaukohta appears to be a typo and should be corrected to Asukohta in this error text.
Suggested fix
- <translation>Aaukohta pole olemas.</translation>
+ <translation>Asukohta pole olemas.</translation>As per coding guidelines, “Fix translation bugs directly in .ts files for placeholder mismatches, broken HTML tags, and mixed-script artifacts.”
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <location filename="../src/configdialog.cpp" line="263"/> | |
| <source>The path does not exist.</source> | |
| <translation>Tee ei eksisteeri.</translation> | |
| <translation>Aaukohta pole olemas.</translation> | |
| </message> | |
| <location filename="../src/configdialog.cpp" line="263"/> | |
| <source>The path does not exist.</source> | |
| <translation>Asukohta pole olemas.</translation> | |
| </message> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@localization/localization_et.ts` around lines 419 - 422, The Estonian
translation for the message with source "The path does not exist." (message at
location ../src/configdialog.cpp line="263") contains a typo "Aaukohta pole
olemas." — update the translation to "Asukohta pole olemas." in
localization_et.ts to correct the spelling.
| <location filename="../src/configdialog.cpp" line="1019"/> | ||
| <source>Failed to create password-store at: %1</source> | ||
| <translation>Paroolisalvestuse loomine ebaõnnestus aadressil %1</translation> | ||
| <translation>salasõnahoidla loomine ei õnnestunus asukohas: %1</translation> | ||
| </message> |
There was a problem hiding this comment.
Fix typo in password-store creation failure message (Line 515).
õnnestunus is a typo in a user-facing error message and should be õnnestunud.
Suggested fix
- <translation>salasõnahoidla loomine ei õnnestunus asukohas: %1</translation>
+ <translation>Salasõnahoidla loomine ei õnnestunud asukohas: %1</translation>As per coding guidelines, “Fix translation bugs directly in .ts files for placeholder mismatches, broken HTML tags, and mixed-script artifacts.”
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <location filename="../src/configdialog.cpp" line="1019"/> | |
| <source>Failed to create password-store at: %1</source> | |
| <translation>Paroolisalvestuse loomine ebaõnnestus aadressil %1</translation> | |
| <translation>salasõnahoidla loomine ei õnnestunus asukohas: %1</translation> | |
| </message> | |
| <location filename="../src/configdialog.cpp" line="1019"/> | |
| <source>Failed to create password-store at: %1</source> | |
| <translation>Salasõnahoidla loomine ei õnnestunud asukohas: %1</translation> | |
| </message> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@localization/localization_et.ts` around lines 513 - 516, Update the Estonian
translation for the source string "Failed to create password-store at: %1" by
fixing the typo in the translated text: change "salasõnahoidla loomine ei
õnnestunus asukohas: %1" to "salasõnahoidla loomine ei õnnestunud asukohas: %1"
in the localization entry that corresponds to that source message.
| <location filename="../src/mainwindow.cpp" line="1015"/> | ||
| <source>That name would resolve outside the password store. Please choose a different name.</source> | ||
| <translation type="unfinished"></translation> | ||
| <translation>Ta nazwa nie będzie rozpoznawana w bazie haseł. Wybierz inną nazwę.</translation> | ||
| </message> |
There was a problem hiding this comment.
Restore the “outside password store” meaning in Line 1272.
Current Polish text changes the validation reason; it should explicitly say the name resolves outside the password store.
Suggested fix
- <translation>Ta nazwa nie będzie rozpoznawana w bazie haseł. Wybierz inną nazwę.</translation>
+ <translation>Ta nazwa wskazywałaby poza magazyn haseł. Wybierz inną nazwę.</translation>As per coding guidelines, “Fix translation bugs directly in .ts files for placeholder mismatches, broken HTML tags, and mixed-script artifacts.”
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <location filename="../src/mainwindow.cpp" line="1015"/> | |
| <source>That name would resolve outside the password store. Please choose a different name.</source> | |
| <translation type="unfinished"></translation> | |
| <translation>Ta nazwa nie będzie rozpoznawana w bazie haseł. Wybierz inną nazwę.</translation> | |
| </message> | |
| <location filename="../src/mainwindow.cpp" line="1015"/> | |
| <source>That name would resolve outside the password store. Please choose a different name.</source> | |
| <translation>Ta nazwa wskazywałaby poza magazyn haseł. Wybierz inną nazwę.</translation> | |
| </message> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@localization/localization_pl.ts` around lines 1270 - 1273, The Polish
translation for the source string "That name would resolve outside the password
store. Please choose a different name." was altered and lost the original
meaning; update the translation in localization_pl.ts for the message
corresponding to mainwindow.cpp (source text above) so it explicitly conveys
that the name would resolve outside the password store (e.g., include phrasing
equivalent to "będzie rozwiązywana poza magazynem haseł") and keep the second
sentence asking to choose a different name; modify the translation for that
<message> entry only so it matches the source intent.
Currently translated at 100.0% (314 of 314 strings) Translation: QtPass/QtPass Translate-URL: https://hosted.weblate.org/projects/qtpass/qtpass/et/
Currently translated at 100.0% (314 of 314 strings) Translation: QtPass/QtPass Translate-URL: https://hosted.weblate.org/projects/qtpass/qtpass/gl/
Currently translated at 100.0% (314 of 314 strings) Translation: QtPass/QtPass Translate-URL: https://hosted.weblate.org/projects/qtpass/qtpass/zh_Hans/
Currently translated at 100.0% (314 of 314 strings) Translation: QtPass/QtPass Translate-URL: https://hosted.weblate.org/projects/qtpass/qtpass/sv/
Currently translated at 100.0% (314 of 314 strings) Translation: QtPass/QtPass Translate-URL: https://hosted.weblate.org/projects/qtpass/qtpass/pl/
weblate
force-pushed
the
weblate-qtpass-qtpass
branch
from
5d92f84 to
3a5612c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@localization/localization_et.ts`:
- Line 164: The Estonian translation in localization_et.ts contains a
nonstandard word "sürjutamiseks" in the SSH_AUTH_SOCK help text; replace that
token with the established word "alistamiseks" so the string reads using
standard Estonian. Locate the translation entry containing "SSH_AUTH_SOCK" or
the sentence fragment "Valikuline asukoht SSH_AUTH_SOCK ..." in
localization_et.ts and update the word "sürjutamiseks" to "alistamiseks" to
maintain consistency with other translations and translator guidelines.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5fabe10b-3e98-4c4e-9e24-e604be1786c0
📒 Files selected for processing (5)
localization/localization_et.tslocalization/localization_gl.tslocalization/localization_pl.tslocalization/localization_sv.tslocalization/localization_zh_CN.ts
| <location filename="../src/configdialog.ui" line="891"/> | ||
| <source>Optional path to override SSH_AUTH_SOCK. Leave empty to auto-probe via gpgconf (issue #543).</source> | ||
| <translation>Valikuline tee SSH_AUTH_SOCK alistamiseks. Jätke tühjaks automaatseks tuvastamiseks gpgconf kaudu (issue #543).</translation> | ||
| <translation>Valikuline asukoht SSH_AUTH_SOCK sürjutamiseks. Automaatseks tuvastamiseks gpgconf kaudu (veateade #543) jäta tühjaks.</translation> |
There was a problem hiding this comment.
Replace the nonstandard term in SSH_AUTH_SOCK help text.
"sürjutamiseks" reads like a made-up/nonstandard form here; use the established "alistamiseks" wording for clarity and consistency.
Suggested fix
- <translation>Valikuline asukoht SSH_AUTH_SOCK sürjutamiseks. Automaatseks tuvastamiseks gpgconf kaudu (veateade `#543`) jäta tühjaks.</translation>
+ <translation>Valikuline asukoht SSH_AUTH_SOCK alistamiseks. Automaatseks tuvastamiseks gpgconf kaudu (veateade `#543`) jäta tühjaks.</translation>As per coding guidelines, “Fix translator-flagged bugs in .ts files including placeholder mismatches, broken HTML tags, made-up words from machine translation, and mixed-script artifacts”.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <translation>Valikuline asukoht SSH_AUTH_SOCK sürjutamiseks. Automaatseks tuvastamiseks gpgconf kaudu (veateade #543) jäta tühjaks.</translation> | |
| <translation>Valikuline asukoht SSH_AUTH_SOCK alistamiseks. Automaatseks tuvastamiseks gpgconf kaudu (veateade `#543`) jäta tühjaks.</translation> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@localization/localization_et.ts` at line 164, The Estonian translation in
localization_et.ts contains a nonstandard word "sürjutamiseks" in the
SSH_AUTH_SOCK help text; replace that token with the established word
"alistamiseks" so the string reads using standard Estonian. Locate the
translation entry containing "SSH_AUTH_SOCK" or the sentence fragment
"Valikuline asukoht SSH_AUTH_SOCK ..." in localization_et.ts and update the word
"sürjutamiseks" to "alistamiseks" to maintain consistency with other
translations and translator guidelines.
4 participants
Translations update from Hosted Weblate for QtPass/QtPass.
Current translation status:
Summary by CodeRabbit