i18n(et,pl): four reviewer-flagged fixes#1474
Merged
Merged
Conversation
et: - "sürjutamiseks" → "alistamiseks" in the SSH_AUTH_SOCK help string. "alistam*" is the term used everywhere else in the file (line 159 "SSH_AUTH_SOCK alistamine:", lines 436/445 for the warning strings), so the SSH_AUTH_SOCK help text now matches. - "Aaukohta pole olemas." → "Asukohta pole olemas." (typo, the path- does-not-exist warning). - "salasõnahoidla loomine ei õnnestunus asukohas: %1" → "salasõnahoidla loomine ei õnnestunud asukohas: %1" (past tense ending "-d", not "-s", for the password-store creation failure). pl: - "That name would resolve outside the password store. Please choose a different name." was rendered "Ta nazwa nie będzie rozpoznawana w bazie haseł. Wybierz inną nazwę." which means "this name won't be recognised in the password store" — drops the security implication (the path escapes the store). Rewritten to "Ta nazwa będzie rozwiązywana poza magazynem haseł. Wybierz inną nazwę." which conveys "will be resolved outside the password store". lrelease6: 314 finished, 0 unfinished in both files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR corrects four localization strings across Estonian and Polish QtPass UI translations. Three Estonian fixes address typos in the SSH_AUTH_SOCK override tooltip, the "path does not exist" error, and the password-store creation failure message. One Polish update rephrases the message for names resolved outside the password store. ChangesLocalization Updates
Possibly related PRs
Suggested labels
Poem
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
annejan
added a commit
that referenced
this pull request
May 13, 2026
…pp (#1475) CodeRabbit's auto-fix on #1471 captured the QFile::write() return value and asserted it equals the payload size — sensible nit. The resulting QVERIFY2 calls busted the 80-col limit and the super-linter is rejecting unrelated PRs (#1474 head was 7430a35) because clang-format runs over the whole tree. Reformat both calls — break after the condition, matches the style of all the other QVERIFY2 sites added in earlier security PRs. No semantic change. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
annejan
added a commit
that referenced
this pull request
May 13, 2026
* chore: clang-format two over-long QVERIFY2 lines in tst_integration.cpp CodeRabbit's auto-fix on #1471 captured the QFile::write() return value and asserted it equals the payload size — sensible nit. The resulting QVERIFY2 calls busted the 80-col limit and the super-linter is rejecting unrelated PRs (#1474 head was 7430a35) because clang-format runs over the whole tree. Reformat both calls — break after the condition, matches the style of all the other QVERIFY2 sites added in earlier security PRs. No semantic change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(keygendialog): widget tests for the GPG keygen dialog KeygenDialog (the modal that fronts GPG key-pair generation) had zero test coverage. Added six widget-level tests in a new tests/auto/ keygendialog/ subdirectory, modelled on the existing tests/auto/ importkeydialog/ pattern: - constructionLoadsNonEmptyTemplate: dialog instantiates, plainTextEdit receives the default GPG batch template (covers both the ed25519 and RSA fallback paths via the shared Name-Real:/Name-Email: substring check). - expertCheckboxTogglesTemplateEditor: toggling the "Expert" checkbox flips plainTextEdit between read-only/disabled and editable/enabled. - nameTextUpdatesNameRealLine: typing in the Name field replaces the Name-Real: line in the template. - emailTextUpdatesNameEmailLine: same for Name-Email:. - matchingPassphrasesEnableButtonBox: identical text in both passphrase fields enables the OK button. - mismatchedPassphrasesDisableButtonBox: differing passphrases disable OK. The dialog is normally parented to ConfigDialog; tests pass nullptr to sidestep ConfigDialog construction. The protected done() slot isn't exercised — it dispatches into dialog->genKey() which dereferences the ConfigDialog parent. Build clean, 8/8 keygendialog tests pass, 46/46 ui tests still pass, doxygen unchanged. Wired into tests/auto/auto.pro SUBDIRS and .gitignore. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(keygendialog): QVERIFY2 + scanner-safe passphrase fixtures Two reviewer nits on #1476: - Replace bare QVERIFY(obj != nullptr) with QVERIFY2(obj != nullptr, "<name> != nullptr") at every findChild site so a future test failure reports which specific widget couldn't be located. - Swap the "secret" passphrase literals in the two passphrase-matching tests for "testkey123" / "testkey456" — gitleaks-friendly fixtures that still exercise the equality / inequality paths. No behavioural change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * test(keygendialog): descriptive QVERIFY2 messages instead of tautological ones CodeRabbit nit on the previous follow-up: "checkBox != nullptr" as a failure message just restates the condition; QVERIFY2 already prints the condition. Switch to the existing "<widget-name> widget must exist" style already used on line 47 for plainTextEdit. No behavioural change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four still-valid reviewer findings against current main.
Why
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit