i18n: finish translations for da, nl_BE, en_GB, et#1447
Conversation
📝 WalkthroughWalkthroughThis PR completes and adds SSH_AUTH_SOCK override translations across four locales: Danish translations are marked finished, English GB translations moved from unfinished to complete, Estonian translations newly filled in, and Dutch-Belgian translations newly added but remain unfinished. ChangesSSH_AUTH_SOCK Multi-Locale Translation Completion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@localization/localization_et.ts`:
- Around line 429-431: Replace the machine-translated term "Unix-domeenisokkel"
in the translation for the source string "The path is not a Unix domain socket."
with the correct Estonian technical term (e.g., "Unixi domeenipesa"), update the
translation value accordingly, and clear the translator flag (remove or change
type="unfinished") so the entry is marked as finalized; locate the entry by the
source text to apply this change.
🪄 Autofix (Beta)
✅ Autofix completed
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: a3d8182b-20c5-4034-aa73-b90befaf8237
📒 Files selected for processing (4)
localization/localization_da.tslocalization/localization_en_GB.tslocalization/localization_et.tslocalization/localization_nl_BE.ts
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Fixes Applied SuccessfullyFixed 1 file(s) based on 1 unresolved review comment. Files modified:
Commit: The changes have been pushed to the Time taken: |
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@localization/localization_et.ts`:
- Around line 429-431: The Estonian translation for the source "The path is not
a Unix domain socket." should be marked as unfinished to match similar
validation entries; update the translation element corresponding to the source
in localization_et.ts (the entry for the string from configdialog.cpp at line
272 / source "The path is not a Unix domain socket.") by adding
type="unfinished" to the <translation> tag so Weblate can pick it up for
refinement, mirroring the treatment used for the nearby validation messages at
lines 421 and 426.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 05d46736-0410-4528-8c7d-6b45fa81eeb4
📒 Files selected for processing (1)
localization/localization_et.ts
| <location filename="../src/configdialog.cpp" line="272"/> | ||
| <source>The path is not a Unix domain socket.</source> | ||
| <translation type="unfinished"></translation> | ||
| <translation>Tee ei ole Unixi domeenipesa.</translation> |
There was a problem hiding this comment.
Mark translation as unfinished for consistency.
While the terminology "Unixi domeenipesa" correctly addresses the past review concern, this translation should be marked type="unfinished" for consistency with the similar validation messages at lines 421 and 426, and to allow Weblate to refine it.
Proposed fix
- <translation>Tee ei ole Unixi domeenipesa.</translation>
+ <translation type="unfinished">Tee ei ole Unixi domeenipesa.</translation>As per coding guidelines, "Fill empty translation entries with best-effort translations marked type="unfinished" for Weblate to refine."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <location filename="../src/configdialog.cpp" line="272"/> | |
| <source>The path is not a Unix domain socket.</source> | |
| <translation type="unfinished"></translation> | |
| <translation>Tee ei ole Unixi domeenipesa.</translation> | |
| <location filename="../src/configdialog.cpp" line="272"/> | |
| <source>The path is not a Unix domain socket.</source> | |
| <translation type="unfinished">Tee ei ole Unixi domeenipesa.</translation> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@localization/localization_et.ts` around lines 429 - 431, The Estonian
translation for the source "The path is not a Unix domain socket." should be
marked as unfinished to match similar validation entries; update the translation
element corresponding to the source in localization_et.ts (the entry for the
string from configdialog.cpp at line 272 / source "The path is not a Unix domain
socket.") by adding type="unfinished" to the <translation> tag so Weblate can
pick it up for refinement, mirroring the treatment used for the nearby
validation messages at lines 421 and 426.
2 participants
Summary
Part of finishing i18n coverage for the SSH_AUTH_SOCK auto-probe + override feature (PR #1438).
Summary by CodeRabbit