[Fix] 0047063 UI: Rating – aria-label on input instead of label#11018
Merged
thibsy merged 2 commits intoILIAS-eLearning:release_11from Mar 11, 2026
Merged
[Fix] 0047063 UI: Rating – aria-label on input instead of label#11018thibsy merged 2 commits intoILIAS-eLearning:release_11from
thibsy merged 2 commits intoILIAS-eLearning:release_11from
Conversation
BettyFromHH
added
the
css/html
Annett7811
reviewed
Feb 13, 2026
Annett7811
left a comment
Annett7811
left a comment
There was a problem hiding this comment.
Hello!
From an accessibility perspective, this looks good. Thank you very much for your work.
Best regards,
Annett
oliversamoila
approved these changes
Feb 23, 2026
Contributor
oliversamoila
left a comment
oliversamoila
left a comment
There was a problem hiding this comment.
Hello together,
from an UX and UI perspective, the result looks good. Thank you very much for your contribution, @fhelfer.
I'm forwarding this to @thibsy for code review. He may contact you with change requests or incorporate the changes directly (That includes cherry picking too.)
Kind regards,
@oliversamoila (as UI coordinator)
thibsy
requested changes
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Hi @fhelfer,
Thx a lot for your contribution to the UI framework!
Please implement the following changes:
- Accessibility: I think we should actually address this issue with existing semantics. The
labelandinputare already linked, so we should render the{ARIALABEL}inside the label and hide it visually using i.e.<span class="sr-only">.
Kind regards,
@thibsy (as UI coordinator)
Contributor
|
quick ping @fhelfer =) |
thibsy
pushed a commit
that referenced
this pull request
Mar 11, 2026
…s. (#11018) * Fixes https://mantis.ilias.de/view.php?id=47063 * Remove `aria-label` on the label element and show its content to assistive technologies only.
thibsy
pushed a commit
that referenced
this pull request
Mar 11, 2026
…s. (#11018) * Fixes https://mantis.ilias.de/view.php?id=47063 * Remove `aria-label` on the label element and show its content to assistive technologies only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error: The “aria-label” attribute must not be used on any “label” element that is associated with a labelable element.
https://mantis.ilias.de/view.php?id=47063
Label with for= must not duplicate name via aria-label. Move
aria-label to the radio input; label remains for click target.
Apply to scale options and neutral option.
Problem
<label for="..." aria-label="...">ungültig, wenn das Label mit Formularelement verknüpft ist; Name soll aus Label-Inhalt kommen.Lösung