[FIX] 046534: Failed test: Vorschau anzeigen über Reiter Info #11037
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfsx
added
bugfix
css/html
thibsy
approved these changes
Feb 3, 2026
Contributor
thibsy
left a comment
thibsy
left a comment
There was a problem hiding this comment.
Hi @chfsx
Thx for the fix, LGTM.
Just some background information for the general public: We currently lack a proper container where we can push our modals and lightboxes to, so this bandaid is way more easily applied than the proper solution would be implemented. Once we have such a container, we don't need to provide unnecessary HTML attributes for different possible parent containers anymore.
Kind regards
@thibsy (as UI coordinator)
thibsy
pushed a commit
that referenced
this pull request
Feb 3, 2026
…iners. (#11037) * Fixes https://mantis.ilias.de/view.php?id=46534 * Add `type="button"` attribute to `<button>` elements of `Modal\Lightbox` components, to support various different parent containers such as `<form>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left/right buttons in a lighbox modal trigger surrounding forms (e.g. the InfoPage is a form, for whatever reason...). this fixes https://mantis.ilias.de/view.php?id=46534