the span with the text “(Selected)” becomes part of the link and read out to screen reader users.#11172
Conversation
…ead out to screen reader users.
oliversamoila
added
bugfix
php
Annett7811
left a comment
Annett7811
left a comment
There was a problem hiding this comment.
Hello!
From an accessibility perspective, this looks good. Thank you very much for your work.
Best regards,
Annett
thibsy
left a comment
thibsy
left a comment
There was a problem hiding this comment.
Thx @satyammangroliya for the second iteration.
For future reference, please try not to cause unnecessary whitespace changes and update existing PR's rather than opening a new ones, this keeps discussion in one place.
Just for transparency, this is merely a bandaid for the fact we lack a proper UI component for tabs; the aria-current="page" attribute on the active link element(s) would be the best possible solution, which cannot be implemented yet.
But this improves accessibility nonetheless, so thx!
Kind regards,
@thibsy (as shepherd)
|
Ah, I cannot merge this yet, the code-style check failed. @satyammangroliya you can probably solve this by undoing some whitespace changes, or run the formatter manually. |
|
Dear @thibsy , |
* Fixes https://mantis.ilias.de/view.php?id=41823 * Add "Selected" text for assistive technologies --------- Co-authored-by: Satyam <satyam@minervis.com>
* Fixes https://mantis.ilias.de/view.php?id=41823 * Add "Selected" text for assistive technologies --------- Co-authored-by: Satyam <satyam@minervis.com>
4 participants
https://mantis.ilias.de/view.php?id=41823