[FIX] #45983 UI: Fix textarea character count#11314
Merged
thibsy merged 1 commit intoMay 13, 2026
Merged
Conversation
Contributor
thibsy
approved these changes
May 13, 2026
Contributor
thibsy
left a comment
thibsy
left a comment
There was a problem hiding this comment.
Hi @corro,
What the heck was going on there =). I also think this is unnecessary. The logic looks like it was meant to guess the appropriate visual length of the string input rather than what is actually entered. But we're in a form context, so that's idiotic.
Normalising the line-breaks inside the getter and only ever using mb_strlen() is much more appropriate and respects what is actually important here: not accidentally breaking the database.. LGMT, thx a lot!
Kind regards,
@thibsy (as shepherd)
thibsy
pushed a commit
that referenced
this pull request
May 13, 2026
thibsy
pushed a commit
that referenced
this pull request
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://mantis.ilias.de/view.php?id=45983