Skip to content

OrgU: #42977, move calls from global to object-specific settings#8538

Open
nhaagen wants to merge 4 commits into
ILIAS-eLearning:release_10from
nhaagen:10/OrgU/42977
Open

OrgU: #42977, move calls from global to object-specific settings#8538
nhaagen wants to merge 4 commits into
ILIAS-eLearning:release_10from
nhaagen:10/OrgU/42977

Conversation

@nhaagen
Copy link
Copy Markdown
Contributor

@nhaagen nhaagen commented Nov 29, 2024

Settings for single repository objecs used to be in ilOrgUnitGlobalSettings; they rather belong to ilOrgUnitObjectPositionSetting.

Then, initialization of the settings is not necessary, they work in a tristate allowing to fall back on global defaults if no explicit value was set.

Please see https://mantis.ilias.de/view.php?id=42977#c110034

@dsstrassner dsstrassner added bugfix jour fixe php Pull requests that update Php code labels Nov 29, 2024
Copy link
Copy Markdown
Contributor

@klees klees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nhaagen,

LGTM in general, I have left two change requests inline.

Kind regards!

@klees
Copy link
Copy Markdown
Contributor

klees commented Dec 2, 2024

Hi @alex40724, hi @kergomard,

could you please have a quick look here? Changes are basically editorial, shouldn't be much effort.

Thanks!

Copy link
Copy Markdown
Contributor

@kergomard kergomard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the changes @nhaagen and @klees . I'm fine with them for RBAC and Object.

Best,
@kergomard

@nhaagen nhaagen requested a review from klees December 2, 2024 12:44
@kergomard
Copy link
Copy Markdown
Contributor

[JourFixe], 09 DEC 2024 : We have discussed the pros and cons and would like to follow the process of creating a new object.
This means that the global definition of the setting is also taken into account when copying and importing an object (in this case: Test) with positions - the global settings override individual settings on the source instance of the object.

@klees
Copy link
Copy Markdown
Contributor

klees commented Jan 20, 2025

@alex40724 Could you please have a look here?

@klees
Copy link
Copy Markdown
Contributor

klees commented Feb 24, 2025

Hi @alex40724,

would you be so kind a have a look here?

Kind regards!

@klees
Copy link
Copy Markdown
Contributor

klees commented May 19, 2025

Hi @alex40724,

could you look into this?

Kind regards!

@klees
Copy link
Copy Markdown
Contributor

klees commented Oct 7, 2025

Hi @alex40724,

would you be so kind and look into this?

Kind regards!

@dsstrassner
Copy link
Copy Markdown
Contributor

Currently there is no authority for OrgUnits.

@matthiaskunkel
Copy link
Copy Markdown
Member

We have an authority for OrgUnits again. I have removed the Shepherd tag and assigned the PR to @maalers . Thanks to Marcel for having a look at it. Feedback from @alex40724 is still pending, if I am not wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants