fix: Remove lineSeparatorPositions check#2823
Closed
Egor18 wants to merge 2 commits intoINRIA:masterfrom
Closed
Conversation
Contributor
Author
|
It seems like Other tests are ok. I can remove the test case, but leave the change. WDYT? |
Collaborator
|
I am having a look at this. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I was trying to migrate from spoon 7.0 to 7.2, and encountered some mode build failures due to the recent changes. (We have a large test base with ~80 open-source projects).
Spoon 7.2. fails to build a model with
spoon.SpoonException: Unexpected lineSeparatorPositionsfor the file with commented out class (the code is from jmonkeyengine project):However, that file compiles successfully, and spoon 7.0 was able to handle it.
I think this issue is related to that commit: f68c62c
So I'd like commented out classes not to fail an entire model build.