fix: CompilationUnit has lineSeparatorPositions even for empty class#2824
Merged
monperrus merged 3 commits intoINRIA:masterfrom Dec 8, 2018
Merged
fix: CompilationUnit has lineSeparatorPositions even for empty class#2824monperrus merged 3 commits intoINRIA:masterfrom
monperrus merged 3 commits intoINRIA:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is alternative to #2823
Thank You Egor for the failing test. I added it as part of this PR.
Then I fixed it by way the compilation unit has correct lineSeparatorPositions even when it is empty.