Make compression robust against special characters in field names#45
Merged
JuliaSprenger merged 9 commits intoINT-NIT:mainfrom Apr 28, 2022
Merged
Make compression robust against special characters in field names#45JuliaSprenger merged 9 commits intoINT-NIT:mainfrom
JuliaSprenger merged 9 commits intoINT-NIT:mainfrom
Conversation
|
Hello @JuliaSprenger! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-04-26 14:07:32 UTC |
JuliaSprenger
added
the
safe to test
Collaborator
Author
|
@killianrochet Can you have a look at this PR? It fixes an issue I just discovered in the compression feature. Do you see how I first extended the test (files) to cover the offending case (first two commits) and then implemented the fix (third commit)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And extend test files accordingly.
Fixes #44
Update: This PR also fixes potential name conflicts that might occur during column merging and extends the test files correspondingly.