created the hbk folder #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prasadtalasila
left a comment
prasadtalasila
left a comment
There was a problem hiding this comment.
@8ohamed thanks for the PR. Please address the review comments. Thanks.
| from paho.mqtt.client import Client as MQTTClient # type: ignore | ||
|
|
||
|
|
||
| def load_json_config(): |
Contributor
There was a problem hiding this comment.
It is better to add type hint for function return type. In this case, it seems to be a json file.
| import sys | ||
| import os | ||
| import unittest | ||
| from unittest.mock import MagicMock |
Contributor
There was a problem hiding this comment.
Please use pytest and pytest-cov.
Collaborator
Author
|
Hi @prasadtalasila I have now pushed the changes to the hbk branch |
This was referenced Feb 22, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have extracted the MQTT client code from cpsns.py, and I have created a test for it.
I also created metadata documentation.