chore(chinlan): bump submodule to develop tip — pulls in log rotation - #20
Merged
Merged
Conversation
Three commits land in Bridge through this bump: 9dde9ea feat(logging): rotate the sandbox file log into a Logs/ subdirectory (#5) e3695dc docs(CAVES): address Copilot review nits from #3 (#6) plus PR #2 / #1 / #3 ancestry already on Chinlan develop. The behavior change Bridge actually inherits is the log rotation: sandbox log moves from <base>/<tag>.log to <base>/Logs/<tag>.log (PascalCase to match Documents/ / Library/) and rotates at 4 MiB across 3 generations. The remaining commits are docs only. No Bridge-side code change is needed — Chinlan's public API (IPALog / IPALoggingInit / IPALogServerStart) is unchanged. Builds: JB + chinlan both clean against the bumped submodule. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the Sources/Chinlan git submodule pointer to the current develop tip to pull Chinlan’s new sandbox log rotation behavior into KiouEngineBridge, without changing Bridge-side call sites (API unchanged: IPALog / IPALoggingInit / IPALogServerStart).
Changes:
- Bump
Sources/Chinlansubmodule pin from90512ec→e3695dc. - Inherits Chinlan log rotation + new on-device log location (
<base>/Logs/<tag>.log) as described in the PR.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the `Sources/Chinlan` submodule pin from `90512ec` to the current Chinlan `develop` tip `e3695dc`. Three Chinlan commits land in Bridge through this:
(plus the PR #1 / #2 / #3 ancestry that was already on Chinlan `develop`.)
The only behavior change Bridge inherits is the log rotation:
Driven by the 80 MB log file observed in the field. The remaining commit (#6) is docs only.
No Bridge-side code change needed — Chinlan's public API (`IPALog` / `IPALoggingInit` / `IPALogServerStart`) is unchanged.
Test plan
🤖 Generated with Claude Code