Skip to content

Call PDF viewer after latex compiling (nbconvert)#4348

Merged
minrk merged 2 commits into
ipython:masterfrom
jakobgager:openpdf
Oct 6, 2013
Merged

Call PDF viewer after latex compiling (nbconvert)#4348
minrk merged 2 commits into
ipython:masterfrom
jakobgager:openpdf

Conversation

@jakobgager
Copy link
Copy Markdown
Contributor

Add a configurable to open the pdf after compiling.
Uses the default application.

adresses #4291

@jakobgager
Copy link
Copy Markdown
Contributor Author

Btw. it seems the configurables of the pdf postprocessor are not registered in the help system, i.e. --help-all does not list the respective options.
How can I correct this?

Comment thread IPython/nbconvert/postprocessors/pdf.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default should probbaly be False

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To represent the original behavior yes, but somehow I'm more inclined to directly open the pdf.
But I will change it to False.

@jakobgager
Copy link
Copy Markdown
Contributor Author

I've only tested with Ubuntu, so maybe a windows and mac user should test this.

@minrk
Copy link
Copy Markdown
Member

minrk commented Oct 4, 2013

How can I correct this?

add postprocessors to L91 of nbconvertapp.

 * move file extension addition outside of function
 * move log statement before function call
 * change default to False
 * add postprocessor to nbconvertapp
@Carreau
Copy link
Copy Markdown
Member

Carreau commented Oct 6, 2013

LGTM.

@damianavila
Copy link
Copy Markdown
Member

+1 to me (but only tested on linux)...

minrk added a commit that referenced this pull request Oct 6, 2013
Call PDF viewer after latex compiling (nbconvert)

Add a configurable to open the pdf after compiling.
Uses the default application.

closes #4291
@minrk minrk merged commit 187d64f into ipython:master Oct 6, 2013
@jakobgager jakobgager deleted the openpdf branch October 6, 2013 19:55
@jakobgager
Copy link
Copy Markdown
Contributor Author

Thanks!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Call PDF viewer after latex compiling (nbconvert)

Add a configurable to open the pdf after compiling.
Uses the default application.

closes ipython#4291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants