Widgets- add ability to pack and unpack arrays on JS side.

[jdfreder]

Fixes #5020

[jdfreder]

Ping @jasongrout for a review

[ellisonbg]

@jdfreder I know you said that testing this would be very tough, but is there any way to verify that it does the expected thing?

[jdfreder]

I know you said that testing this would be very tough, but is there any way to verify that it does the expected thing?

Actually I don't think it would be bad at all. For some reason I was thinking of round trip tests, but all I need to do is test the function itself.

[ellisonbg]

OK, that would be great. If we can get a passing tests, I will merge :)

On Tue, Feb 4, 2014 at 3:03 PM, Jonathan Frederic
notifications@github.comwrote:

I know you said that testing this would be very tough, but is there any
way to verify that it does the expected thing?

Actually I don't think it would be bad at all. For some reason I was
thinking of round trip tests, but all I need to do is test the function
itself.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5023#issuecomment-34118594
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[jdfreder]

Hmmm the tests pass locally.... I wonder what is going on

[ellisonbg]

They are still running...

[jdfreder]

I just checked in 8978fb4, but the previous commit, a8647ac worked on my machine, but not on Travis.

[jdfreder]

Woohoo they pass, @ellisonbg do you want to merge?

[ellisonbg]

Yep, great!

[jasongrout]

ping @ChakriCherukuri, just to make sure you know this got merged into master. Thanks for bringing this issue up!

[jasongrout]

(I didn't have time to review this, but glancing at the code, it looks great!)