64 & 66 - Add optional dataset fields alternativePersistentId, publicationDate and citationDate #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
previously approved these changes
Jun 20, 2023
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I didn't run the code but tests are passing and the changes make sense.
Please note the other PR noted should be merged first.
… into 64-66-optional-dataset-fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the optional fields alternativePersistentId, publicationDate and citationDate to the dataset model and their transformation in case they are returned from the API.
This branch is created from
65-modify-the-dataset-type-description-to-explicitly-declare-the-citation-metadata-fieldsso PR #67 should be merged first.Which issue(s) this PR closes:
Special notes for your reviewer:
Optional parameters need IQSS/dataverse#9657 to work
Suggestions on how to test this:
I've added one of the optional fields to the
datasetHelper.tstest response payload and test model to test the model transformation when only one optional field is sent.Is there a release notes update needed for this change?:
No
Additional documentation:
N/A