Search results map - #1027
Draft
julian-schneider wants to merge 3 commits into
Draft
Conversation
based on the custom footer PoC by Paul Boon
Author
|
@julian-schneider Great work! |
Member
|
FWIW: Using ?query_entities=false in the Dataverse API is a factor or 10x faster, so unless you needed the added info, I'd definitely add it. |
- pins are now placed in the averaged center of bboxes - when clicking a pin, the map zooms out to show all bboxes - while popup & bboxes are displayed, the pin will not be clustered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does / why we need it:
Adds a browsable map of all search results with geospatial information. It is located in a tab on the search results page, as an alternative to the normal list of search results. The map displays one pin per dataset, which can be clicked for a small preview that leads the user to the details page. Clusters of pins are grouped to declutter the area.
This implementation is entirely based on the proof of concept by @PaulBoon described in detail here. That PoC uses a custom footer to inject the map into the classic UI, while this implementation is based on
react-leaflet.This PR is a work-in-progress draft version. Some open issues I'm aware of:
Which issue(s) this PR closes:
Suggestions on how to test this:
Populate an installation with datasets filling out the official geospatial metadata block, and the map should display them.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes. The map was entirely based on the design of the previously-mentioned PoC.
Is there a release notes or changelog update needed for this change?:
Yes