Preview of draft file with retention period causes internal server error

[jo-pol]

What steps does it take to reproduce the issue?

Add a file to a dataset, set a retention period (with or without a reason), do not publish, try to preview the file with a retention period.

• When does this issue occur?

When trying to preview a draft file with a retention period

• Which page(s) does it occurs on?

files

• What happens?

Internal server error: java.lang.NullPointerException: Cannot invoke "String.isEmpty()" because "str" is null
Top of the stack trace:

at java.lang.String.concat(String.java:2771)
at jdk.internal.reflect.GeneratedMethodAccessor374.invoke(Unknown Source:-1)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:569)
at jakarta.el.ELUtil.invokeMethod(ELUtil.java:215)
at jakarta.el.BeanELResolver.invoke(BeanELResolver.java:487)
at jakarta.el.CompositeELResolver.invoke(CompositeELResolver.java:198)
at org.glassfish.expressly.parser.AstValue.getValue(AstValue.java:298)
at org.glassfish.expressly.parser.AstValue.getValue(AstValue.java:144)
at org.glassfish.expressly.parser.AstChoice.getValue(AstChoice.java:44)
at org.glassfish.expressly.ValueExpressionImpl.getValue(ValueExpressionImpl.java:138)
    this: "ValueExpression[#{(empty FilePage.file.embargo) and !(empty FilePage.file.released) and !(empty FilePage.file.retention) ? ''.concat(FilePage.file.publicationDateFormattedYYYYMMDD).concat('; ') : ''}]"
at org.jboss.weld.module.web.el.WeldValueExpression.getValue(WeldValueExpression.java:50)

dataverse/src/main/webapp/file.xhtml

Lines 569 to 576 in ac8bdc1

	<td>#{(empty FilePage.file.embargo) and !(empty FilePage.file.released) and !(empty FilePage.file.retention) ? ''.concat(FilePage.file.publicationDateFormattedYYYYMMDD).concat('; ') : ''}
	#{!(empty FilePage.file.embargo) ? ''.concat(FilePage.embargoPhrase).concat(' ').concat(FilePage.file.embargo.dateAvailable) : ''}
	#{!(empty FilePage.file.embargo) and !(empty FilePage.file.retention) ? '; ': ''}
	#{!(empty FilePage.file.retention) ? ''.concat(FilePage.retentionPhrase)
	.concat(' ').concat(FilePage.file.retention.dateUnavailable)
	.concat(', ').concat(bundle['retention.enddateinfo'])
	: ''}
	#{(empty FilePage.file.embargo and empty FilePage.file.retention)? FilePage.file.publicationDateFormattedYYYYMMDD : ''}

• To whom does it occur (all users, curators, superusers)?

Curators and dataset owners

• What did you expect to happen?

Which version of Dataverse are you using?

v6.9

Any related open or closed issues to this bug report?

#12432 applies to embargo and retention. This issue applies only to the retention period.

Screenshots:

No matter the issue, screenshots are always welcome.

To add a screenshot, please use one of the following formats and/or methods described here:

• https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests

Are you thinking about creating a pull request for this issue?
Help is always welcome, is this bug something you or your organization plan to fix?