Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: Shapefile "repackaging" is skipping ".cpg" files #3556

Closed
raprasad opened this Issue Jan 4, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@raprasad
Copy link
Contributor

raprasad commented Jan 4, 2017

Dataverse should handle shapefiles as described here:

However, there's a bug where ".cpg" files aren't being re-packaged.

Fix

File: ShapefileHandler.java

  • Current line with Bug. Should be cpg, not .cpg
    public final static List<String> SHAPEFILE_ALL_EXTENSIONS = Arrays.asList("shp", "shx", "dbf", "prj", "sbn", "sbx", "fbn", "fbx", "ain", "aih", "ixs", "mxs", "atx", ".cpg", SHP_XML_EXTENSION);  
  • Fixed line:
    public final static List<String> SHAPEFILE_ALL_EXTENSIONS = Arrays.asList("shp", "shx", "dbf", "prj", "sbn", "sbx", "fbn", "fbx", "ain", "aih", "ixs", "mxs", "atx", "cpg", SHP_XML_EXTENSION);  

@raprasad raprasad self-assigned this Jan 4, 2017

raprasad added a commit that referenced this issue Jan 5, 2017

@raprasad raprasad removed their assignment Jan 5, 2017

@raprasad raprasad self-assigned this Jan 5, 2017

@raprasad raprasad referenced this issue Jan 5, 2017

Merged

Fix for #3556 #3557

6 of 11 tasks complete

@djbrooke djbrooke assigned pdurbin and unassigned raprasad Jan 5, 2017

@pdurbin

This comment has been minimized.

Copy link
Member

pdurbin commented Jan 5, 2017

Pull request #3557 has more than a one character fix, but makes sense and has a test in ShapefileHandlerTest.java, which makes me happy. Travis is happy too (build and tests pass): https://travis-ci.org/IQSS/dataverse/builds/189214989

I'm moving this to QA in https://waffle.io/IQSS/dataverse

@raprasad

This comment has been minimized.

Copy link
Contributor Author

raprasad commented Jan 5, 2017

more than a one character fix

... well, one character without the tests:)

@djbrooke

This comment has been minimized.

Copy link
Contributor

djbrooke commented Jan 5, 2017

One could say this was a good test of (a) character.

kcondon added a commit that referenced this issue Jan 23, 2017

@kcondon kcondon self-assigned this Jan 23, 2017

@kcondon

This comment has been minimized.

Copy link
Contributor

kcondon commented Jan 23, 2017

Tested against all 15 supported file extensions as well as one not supported for comparison. Works, closing.

@kcondon kcondon closed this Jan 23, 2017

@kcondon kcondon removed the Status: QA label Jan 23, 2017

lwo added a commit to IISH/dataverse that referenced this issue Apr 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.