Skip to content

Undesired behaviour when uploading multiple files via GUI and direct upload  #8408

@haarli

Description

@haarli

During tests with the current Dataverse 5.9, we discovered a strange behaviour with direct uploads via GUI.

  • Prerequisite: Direct upload must be enabled
  • Create a new dataset
  • Click "Upload Files" button
  • Click "Select Files to add"
  • Select multiple files (at least 20)

The upload is starting correctly, but stops before the last few files (2-6) are uploaded. GUI is still responsive, but nothing happens anymore. When clicking done, none of the files are added to the dataset
grafik

This behaviour can be reproduced, but there's always a different amount of items that are not uploaded. It seems to be a concurrency problem.
In the JS console, some NPEs are visible:
Uncaught (in promise) TypeError: upload is null (fileupload.js.xhtml:411:36)

I will provide a pull request with a quite simple fix for this issue, but I don't really understand the original intention of the code snippet. So a review would be great.

Thanks
Markus

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions