#10861 add activate banner Message by API admin#10862
Closed
ghost wants to merge 3 commits intoIQSS:developfrom
Closed
#10861 add activate banner Message by API admin#10862ghost wants to merge 3 commits intoIQSS:developfrom
ghost wants to merge 3 commits intoIQSS:developfrom
Conversation
pdurbin
reviewed
Sep 19, 2024
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Thanks for the PR. Some quick thoughts.
| @@ -5508,6 +5508,10 @@ Deactivate a Banner Message by its id (allows you to hide a message while retain | |||
|
|
|||
Member
There was a problem hiding this comment.
I'll just add this comment here at the top...
Can you please add a release note snippet? https://guides.dataverse.org/en/6.3/developers/version-control.html#writing-release-note-snippets
| } | ||
| } | ||
|
|
||
| public void activateBannerMessage(Object pk) { |
Member
There was a problem hiding this comment.
First, maybe this should be called reactivate.
If you reactivate a banner message, what happens to the "mark as read" state of the message for users? Does it show as read or unread? Do you want it to be unread when you reactivate the message?
From this comment, we added deactivate "to retain the history of users' dismissals of messages while hiding out of date messages": #7434 (comment)
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add function to enable message
Which issue(s) this PR closes:
Closes #10861
Special notes for your reviewer:
When a message is deactivated, it should be made visible again.
Additional documentation:
yes