Skip to content

Conversation

@landreev
Copy link
Contributor

@landreev landreev commented May 21, 2025

What this PR does / why we need it:

documentation only, self-explanatory, preview at https://dataverse-guide--11510.org.readthedocs.build/en/11510/user/tabulardataingest/stata.html

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@github-actions github-actions bot added FY25 Sprint 23 FY25 Sprint 23 (2025-05-07 - 2025-05-21) Size: 10 A percentage of a sprint. 7 hours. Type: Feature a feature request labels May 21, 2025
@landreev landreev moved this to Ready for Review ⏩ in IQSS Dataverse Project May 21, 2025
@pdurbin pdurbin moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project May 22, 2025
@pdurbin pdurbin self-assigned this May 22, 2025
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple comments.

.. contents:: |toctitle|
:local:

Of all the third party statistical software providers, Stata does the best job at documenting the internal format of their files, by far. And at making that documentation freely and easily available to developers (yes, we are looking at you, SPSS). Because of that, Stata is the best supported format for tabular data ingest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has always cracked me up: "yes, we are looking at you, SPSS" 😄

Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project May 22, 2025
@ofahimIQSS ofahimIQSS self-assigned this May 22, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project May 22, 2025
@landreev
Copy link
Contributor Author

Thanks for adding the preview link @pdurbin

typo

Co-authored-by: Omer Fahim <mfahim11427@gmail.com>
@ofahimIQSS
Copy link
Contributor

proofread, looks good - merging.

@ofahimIQSS ofahimIQSS merged commit e560492 into develop May 22, 2025
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project May 22, 2025
@ofahimIQSS ofahimIQSS deleted the 11219-stata-versions branch May 22, 2025 17:11
@ofahimIQSS ofahimIQSS removed their assignment May 22, 2025
@landreev
Copy link
Contributor Author

Thanks for the fix @ofahimIQSS , committed.
Please feel free to just commit directly, when it's typos/misspellings and such.
Also, I just killed the Jenkins build triggered by committing the typo fix - no need to waste Jenkins's time.

@pdurbin pdurbin added this to the 6.7 milestone May 22, 2025
@pdurbin pdurbin moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY25 Sprint 23 FY25 Sprint 23 (2025-05-07 - 2025-05-21) Size: 10 A percentage of a sprint. 7 hours. Type: Feature a feature request

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Ingest: Update Stata ingest doc to clarify how different formats are supported

4 participants