Dataset page: Use params for clarity and efficiency #11611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Jul 11, 2025
Contributor
stevenwinship
left a comment
stevenwinship
left a comment
There was a problem hiding this comment.
The current performance tests will most likely not see a significant change due to the limited number of datasets being tested. I would like to re-run them once this pr is merged into develop. If the tests show improvement (perf or other tests) then we should make the changes to other areas. I don't want to hold up this pr to extend it. A new issue can be created once we run more performance tests.
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
Member
Author
|
Should be fixed - was missing a commit fixing errors in the editFileFragment.xhtml file. |
Contributor
|
Looks good, nothing else stood out during testing. I'll merge once continuous integration finishes running. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR defines and uses jsf params in dataset.xhtml page and several things it includes. The intent was to improve efficiency and clarity. There should be no functional change.
Which issue(s) this PR closes:
Special notes for your reviewer: In some quick testing at QDR, I thought I could see some improvement in page load times with the changes here. If that can be confirmed by @landreev or @stevenwinship with more formal performance testing, this could be merged as is or expanded to include the dataverse and/or other pages.
Suggestions on how to test this: Regression and performance testing.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: