Skip to content

12141 - Storage Driver API#12182

Draft
jp-tosca wants to merge 13 commits intodevelopfrom
storage-driver-endpoint
Draft

12141 - Storage Driver API#12182
jp-tosca wants to merge 13 commits intodevelopfrom
storage-driver-endpoint

Conversation

@jp-tosca
Copy link
Contributor

@jp-tosca jp-tosca commented Feb 25, 2026

What this PR does / why we need it:

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@jp-tosca jp-tosca self-assigned this Feb 25, 2026
@jp-tosca jp-tosca moved this to In Progress 💻 in IQSS Dataverse Project Feb 25, 2026
@jp-tosca jp-tosca added GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 50 A percentage of a sprint. 35 hours. Project: HDV SPA Rollout labels Feb 25, 2026
@cmbz cmbz added the FY26 Sprint 17 FY26 Sprint 17 (2026-02-11 - 2026-02-25) label Feb 25, 2026
@github-actions

This comment has been minimized.

@cmbz cmbz added the FY26 Sprint 18 FY26 Sprint 18 (2026-02-25 - 2026-03-11) label Feb 26, 2026
@github-actions

This comment has been minimized.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses #12141 by moving Dataverse Storage Driver endpoints out of the Admin API namespace and exposing them under the Dataverses API.

Changes:

  • Moved storage driver GET/PUT/DELETE endpoints from /api/admin/dataverse/{alias}/storageDriver to /api/dataverses/{identifier}/storageDriver.
  • Replaced the former “list storage drivers” admin endpoint with a dataverse-scoped endpoint intended to list allowed drivers.
  • Updated integration tests and admin docs/release notes to reflect the endpoint move.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 20 comments.

Show a summary per file
File Description
src/test/java/edu/harvard/iq/dataverse/api/UtilIT.java Updates helper methods to call the new dataverses storage driver endpoints (but list path currently mismatches new API).
src/test/java/edu/harvard/iq/dataverse/api/S3AccessIT.java Updates calls to the storage-driver listing helper to include a dataverse alias.
src/test/java/edu/harvard/iq/dataverse/api/DatasetsIT.java Updates storage-driver listing helper usage for dataset storage driver test.
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/SetDataverseStorageDriverCommand.java New command to set a collection’s storage driver by label.
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GetDataverseStorageDriverCommand.java New command to fetch direct/effective storage driver id with release-based permission requirements.
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GetDataverseAllowedStorageDriverCommand.java New command to list drivers (currently returns all drivers; permission model may need alignment).
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DeleteDataverseStorageDriverComman.java New command to reset a collection’s configured storage driver (class name contains a typo).
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/SetDataverseMetadataLanguageCommand.java Removes an unused import.
src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java Adds new /storageDriver and /allowedStorageDrivers endpoints under /api/dataverses/{identifier}; removes unrelated commented-out logo code; introduces unused imports.
src/main/java/edu/harvard/iq/dataverse/api/Admin.java Removes the old admin storage driver endpoints.
src/main/java/edu/harvard/iq/dataverse/api/Info.java Adds imports but currently leaves them unused (compile-breaking).
doc/sphinx-guides/source/admin/dataverses-datasets.rst Updates curl examples to the new endpoint locations; superuser-only wording likely no longer matches implementation.
doc/release-notes/12141-storage-driver-endpoints.md Adds release note for breaking endpoint changes; contains typos and path accuracy issues.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jp-tosca jp-tosca moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Mar 3, 2026
@jp-tosca jp-tosca removed their assignment Mar 3, 2026
@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:storage-driver-endpoint
ghcr.io/gdcc/configbaker:storage-driver-endpoint

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 17 FY26 Sprint 17 (2026-02-11 - 2026-02-25) FY26 Sprint 18 FY26 Sprint 18 (2026-02-25 - 2026-03-11) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Project: HDV SPA Rollout Size: 50 A percentage of a sprint. 35 hours.

Projects

Status: Ready for Review ⏩

Development

Successfully merging this pull request may close these issues.

API Get Dataverse Storage Driver

3 participants